GNOME Bugzilla – Bug 727878
qtdemux: replace duplicated variable when parsing trex atom
Last modified: 2014-04-10 07:14:50 UTC
Created attachment 273853 [details] [review] remove duplicated code I found duplicated code in qtdemux_parse_trex function again. The following patch remove duplicated source code in qtdemux.
Created attachment 273854 [details] [review] remove duplicated code
Comment on attachment 273854 [details] [review] remove duplicated code See the comment above the first one. It reads the sample description index, then the second one reads the duration into the same variable and overwrites it. Maybe change the first one to write to a dummy variable that is not used elsewhere... for clarity. But the code is correct
OK I see. how about change to following patch? I thinks that it's better for code readability. (In reply to comment #2) > (From update of attachment 273854 [details] [review]) > See the comment above the first one. It reads the sample description index, > then the second one reads the duration into the same variable and overwrites > it. > > Maybe change the first one to write to a dummy variable that is not used > elsewhere... for clarity. But the code is correct
Created attachment 273866 [details] [review] remove duplicagted code and add variable How about to change following patch? I think that it's better for code readability
Comment on attachment 273866 [details] [review] remove duplicagted code and add variable Yes, can you attach it in "git format-patch" format with your real name and mail address? :)
Ok I upload the patch. is it right? thank you for your help. :)
Created attachment 273872 [details] [review] replace duplicated variable when parsing trex atom
(In reply to comment #5) > (From update of attachment 273866 [details] [review]) > Yes, can you attach it in "git format-patch" format with your real name and > mail address? :) (In reply to comment #5) > (From update of attachment 273866 [details] [review]) > Yes, can you attach it in "git format-patch" format with your real name and > mail address? :) Ok I upload the patch. is it right? thank you for your help. :)
Comment on attachment 273872 [details] [review] replace duplicated variable when parsing trex atom Could you use your name there instead of having first and last name separated by a .? You can also use non-latin characters for the name btw.
(In reply to comment #9) > (From update of attachment 273872 [details] [review]) > Could you use your name there instead of having first and last name separated > by a .? You can also use non-latin characters for the name btw. I modified it. you are very kind. :)
Created attachment 273873 [details] [review] replace duplicated variable when parsing trex atom
(In reply to comment #9) > (From update of attachment 273872 [details] [review]) > Could you use your name there instead of having first and last name separated > by a .? You can also use non-latin characters for the name btw. Can I use english name? I upload patch again as modified my name to english. I'm first time upload source code to open source site. sorry about that. please understand it.
Created attachment 273878 [details] [review] replace duplicated variable when parsing trex atom
Thanks for updating the patch :) Yes, using the latin version of your name is fine too. Just wanted to make sure you know that you can also use non-latin characters there in case you preferred the non-transliterated version of your name :) commit ecf188e6cd91554ce3a011e37f572ec41909ce18 Author: Jimmy Ohn <yongjin.ohn@lge.com> Date: Wed Apr 9 17:30:54 2014 +0900 qtdemux: replace duplicated variable when parsing trex atom https://bugzilla.gnome.org/show_bug.cgi?id=727878
thank you very much for your help :) I found my name below site. wow! http://cgit.freedesktop.org/gstreamer/gst-plugins-good/