After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 727867 - qtdemux: Does not return stream flags from trex atom
qtdemux: Does not return stream flags from trex atom
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
1.x
Other Linux
: Normal enhancement
: 1.3.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-04-09 01:03 UTC by Jimmy Ohn
Modified: 2014-04-09 06:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
The following patch remove duplicated source code in qtdemux. (462 bytes, patch)
2014-04-09 01:04 UTC, Jimmy Ohn 		committed Details | Review

Description Jimmy Ohn 2014-04-09 01:03:16 UTC 
I found duplicated source code in qtdemux_parse_trex function.
When we get the default sample size in this function, it's duplicated.
For code efficiency, we should remove it.
The following patch remove duplicated source code in qtdemux.
Comment 1 Jimmy Ohn 2014-04-09 01:04:48 UTC 
Created attachment 273842 [details] [review]
The following patch remove duplicated source code in qtdemux.
Comment 2 Sebastian Dröge (slomo) 2014-04-09 06:59:19 UTC 
Thanks for the patch, but actually it should've returned the stream flags there in the second line :)

commit d47806320d13df5e2c8db7e07a87c54c75c5b6a1
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Wed Apr 9 08:58:04 2014 +0200

    qtdemux: Properly return stream flags when parsing trex atom
    
    https://bugzilla.gnome.org/show_bug.cgi?id=727867