After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 727786 - Semi-colon and comma cleanups
Semi-colon and comma cleanups
Status: RESOLVED FIXED
Product: gjs
Classification: Bindings
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gjs-maint
gjs-maint
Depends on:
Blocks:
 
 
Reported: 2014-04-07 22:41 UTC by Mattias Bengtsson
Modified: 2014-04-10 22:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Semi-colon and comma cleanups (11.70 KB, patch)
2014-04-07 22:41 UTC, Mattias Bengtsson 		committed Details | Review

Description Mattias Bengtsson 2014-04-07 22:41:15 UTC 
Add a lot of missing semicolons and remove a few excessive commas.

I got inspired by my previous patch and checked all
the remaining JavaScript too. I hope this is wanted and not just noise.
Comment 1 Mattias Bengtsson 2014-04-07 22:41:19 UTC 
Created attachment 273752 [details] [review]
Semi-colon and comma cleanups

Add lots of missing semi colons (the ones that js2-mode could spot for
me).
Remove a few excessive commas in object initializations.
Comment 2 Colin Walters 2014-04-10 19:43:53 UTC 
Review of attachment 273752 [details] [review]:

Looks good.
Comment 3 Mattias Bengtsson 2014-04-10 22:46:19 UTC 
Attachment 273752 [details] pushed as 945fd01 - Semi-colon and comma cleanups