Created attachment 273549 [details] [review]
data: Add DesktopNames to the session file

So that GDM can export the XDG_CURRENT_DESKTOP environment variable.

See also https://bugzilla.gnome.org/show_bug.cgi?id=727546

Are you sure you don't mean to modify https://git.gnome.org/browse/gnome-session/tree/data/gnome.session.desktop.in.in ?

That's the support for GNOME Classic, which is shipped in gnome-shell-extensions. The changes for the file you mentioned above are in bug 727565.

Review of attachment 273549 [details] [review]:

OK

Attachment 273549 [details] pushed as 110e747 - data: Add DesktopNames to the session file

This commit breaks gnome-classic session: see http://build.gnome.org/continuous/buildmaster/builds/2014/05/05/18/smoketest-classic/work-gnome-continuous-x86_64-runtime/journal.txt. The session seems to get closed for some reason

(In reply to comment #6)
> This commit breaks gnome-classic session: see
> http://build.gnome.org/continuous/buildmaster/builds/2014/05/05/18/smoketest-classic/work-gnome-continuous-x86_64-runtime/journal.txt.
> The session seems to get closed for some reason

There's really nothing to see in the logs. And as the patch is committed, and obviously correct, you should file a separate bug about whatever problem this is.

One of our more gnomic testers, poma, referenced the same commit in a downstream Fedora bug about GNOME Classic not working:

https://bugzilla.redhat.com/show_bug.cgi?id=1120283

and posted this patch:

https://bugzilla.redhat.com/attachment.cgi?id=918676&action=diff

I think what he's saying is that applying that patch makes Classic work, presumably "GNOME-Classic" is not considered a valid value somewhere and that breaks stuff (or just the passing of multiple desktop names is broken, or whatever).

I confirmed the problem Vadim and poma saw, and filed a new bug:

https://bugzilla.gnome.org/show_bug.cgi?id=733376