After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 727484 - gstpad: Don't print name of an unowned event
gstpad: Don't print name of an unowned event
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 1.3.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-04-02 09:28 UTC by Linus Svensson
Modified: 2014-04-12 10:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (1.02 KB, patch)
2014-04-02 09:28 UTC, Linus Svensson 		needs-work Details | Review
Proposed patch (1.58 KB, patch)
2014-04-11 19:30 UTC, Linus Svensson 		committed Details | Review

Description Linus Svensson 2014-04-02 09:28:36 UTC 
Created attachment 273457 [details] [review]
Proposed patch

The name of an event is printed when ownership is given away.

Attached a patch that removes the name in the print.
Comment 1 Sebastian Dröge (slomo) 2014-04-02 21:00:20 UTC 
Comment on attachment 273457 [details] [review]
Proposed patch

It might be more useful to keep the event type around and then include it in the debug output. It's usually very useful information to have there, instead of having to compare pointer values.
Comment 2 Linus Svensson 2014-04-11 19:26:31 UTC 
Ok. I found that the event_type is already around in this function. So I will just replace the macro with the function, that actually translates the event type to a string.

If I can, I will try to update patches faster in the future.
Comment 3 Linus Svensson 2014-04-11 19:30:23 UTC 
Created attachment 274129 [details] [review]
Proposed patch
Comment 4 Tim-Philipp Müller 2014-04-12 10:49:50 UTC 
Thanks! Pushed (minus the common submodule change):

commit cb554772e5c868b0766b445f98de0b52c0e162d6
Author: Linus Svensson <linussn@axis.com>
Date:   Tue Apr 1 15:38:54 2014 +0200

    pad: don't access unowned and possibly already freed event
    
    Don't print the name of the event when ownership is given away.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=727484