After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 727417 - hlssink: allow key-frame to be handled without sending force-key-unit messages
hlssink: allow key-frame to be handled without sending force-key-unit messages
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
1.x
Other All
: Normal enhancement
: NONE
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-04-01 08:01 UTC by Marc Olzheim
Modified: 2018-01-27 12:00 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to add a force-key-unit flag to hlssink. (4.93 KB, patch)
2014-04-01 08:01 UTC, Marc Olzheim
none Details | Review

Description Marc Olzheim 2014-04-01 08:01:47 UTC
Created attachment 273383 [details] [review]
Patch to add a force-key-unit flag to hlssink.

If you wish to use hlssink without (re-)encoding, nothing will be listening to the force key unit messages, resulting in errors:

gsthlssink.c:503:schedule_next_key_unit:<hlssink0> Failed to push upstream force key unit event

This patch adds a flag preventing the force key unit messages to be sent, relying on existing key frames. This may (and probably will) result in non-standard-adhering segments, but if you don't care about that, this will do fine.

It will set multifilesink->next-file to 2 instead of 3 to make this work.
Comment 1 Tim-Philipp Müller 2018-01-27 12:00:22 UTC
Thanks for the patch. Sorry no one ever looked at it.

We now have hlssink2 which should handle this case properly I think.