GNOME Bugzilla – Bug 727384
[Regression] OSD does not display minimum brightness level
Last modified: 2014-04-25 20:05:53 UTC
I can change my brightness to all seven levels, but the lowest level does not display correctly on the OSD (it stays at the second highest level). In the menu, it displays correctly. Bug 710380 is probably related. This is probably just a rounding error or something.
Created attachment 273331 [details] Video of the issue Obviously the brightness level isn't recorded in a screencast, but there is something of interest: the OSD level goes down *slightly* ~3 seconds. This is upon having reached the minimum brightness level and then having gone back up. So again, probably some rounding error.
Which machine is this? What's the output of "xrandr --verbose" when at the lowest level of brightness?
Samsung RV520; Intel HD 3000 graphics, with 7 brightness levels. Output on lowest brightness: [conley@styrka ~]$ xrandr --verbose Screen 0: minimum 8 x 8, current 1366 x 768, maximum 32767 x 32767 LVDS1 connected primary 1366x768+0+0 (0x48) normal (normal left inverted right x axis y axis) 344mm x 194mm Identifier: 0x42 Timestamp: 34295 Subpixel: horizontal rgb Gamma: 1.0:1.0:1.0 Brightness: 1.0 Clones: CRTC: 0 CRTCs: 0 1 Transform: 1.000000 0.000000 0.000000 0.000000 1.000000 0.000000 0.000000 0.000000 1.000000 filter: _MUTTER_PRESENTATION_OUTPUT: 0 EDID: 00ffffffffffff004ca3415400000000 00150103802213780a8da59d5b559c26 19505400000001010101010101010101 010101010101841b5678500016303020 250058c2100000190000000f00000000 00000000002387026401000000fe0053 414d53554e470a2020202020000000fe 004c544e313536415431354330340059 BACKLIGHT: 0 range: (0, 7) Backlight: 0 range: (0, 7) scaling mode: Full aspect supported: None, Full, Center, Full aspect 1366x768 (0x48) 70.440MHz -HSync -VSync *current +preferred h: width 1366 start 1414 end 1446 total 1486 skew 0 clock 47.40KHz v: height 768 start 770 end 775 total 790 clock 60.00Hz 1024x768 (0xa3) 65.000MHz -HSync -VSync h: width 1024 start 1048 end 1184 total 1344 skew 0 clock 48.36KHz v: height 768 start 771 end 777 total 806 clock 60.00Hz 800x600 (0xa4) 40.000MHz +HSync +VSync h: width 800 start 840 end 968 total 1056 skew 0 clock 37.88KHz v: height 600 start 601 end 605 total 628 clock 60.32Hz 800x600 (0xa5) 36.000MHz +HSync +VSync h: width 800 start 824 end 896 total 1024 skew 0 clock 35.16KHz v: height 600 start 601 end 603 total 625 clock 56.25Hz 640x480 (0xa6) 25.175MHz -HSync -VSync h: width 640 start 656 end 752 total 800 skew 0 clock 31.47KHz v: height 480 start 490 end 492 total 525 clock 59.94Hz VGA1 disconnected (normal left inverted right x axis y axis) Identifier: 0x43 Timestamp: 34295 Subpixel: unknown Clones: CRTCs: 0 1 Transform: 1.000000 0.000000 0.000000 0.000000 1.000000 0.000000 0.000000 0.000000 1.000000 filter: HDMI1 disconnected (normal left inverted right x axis y axis) Identifier: 0x44 Timestamp: 34295 Subpixel: unknown Clones: CRTCs: 0 1 Transform: 1.000000 0.000000 0.000000 0.000000 1.000000 0.000000 0.000000 0.000000 1.000000 filter: Broadcast RGB: Automatic supported: Automatic, Full, Limited 16:235 audio: auto supported: force-dvi, off, auto, on DP1 disconnected (normal left inverted right x axis y axis) Identifier: 0x45 Timestamp: 34295 Subpixel: unknown Clones: CRTCs: 0 1 Transform: 1.000000 0.000000 0.000000 0.000000 1.000000 0.000000 0.000000 0.000000 1.000000 filter: Broadcast RGB: Automatic supported: Automatic, Full, Limited 16:235 audio: auto supported: force-dvi, off, auto, on VIRTUAL1 disconnected (normal left inverted right x axis y axis) Identifier: 0x46 Timestamp: 34295 Subpixel: no subpixels Clones: CRTCs: 2 Transform: 1.000000 0.000000 0.000000 0.000000 1.000000 0.000000 0.000000 0.000000 1.000000 filter: Output on second lowest brightness: Screen 0: minimum 8 x 8, current 1366 x 768, maximum 32767 x 32767 LVDS1 connected primary 1366x768+0+0 (0x48) normal (normal left inverted right x axis y axis) 344mm x 194mm Identifier: 0x42 Timestamp: 34295 Subpixel: horizontal rgb Gamma: 1.0:1.0:1.0 Brightness: 1.0 Clones: CRTC: 0 CRTCs: 0 1 Transform: 1.000000 0.000000 0.000000 0.000000 1.000000 0.000000 0.000000 0.000000 1.000000 filter: _MUTTER_PRESENTATION_OUTPUT: 0 EDID: 00ffffffffffff004ca3415400000000 00150103802213780a8da59d5b559c26 19505400000001010101010101010101 010101010101841b5678500016303020 250058c2100000190000000f00000000 00000000002387026401000000fe0053 414d53554e470a2020202020000000fe 004c544e313536415431354330340059 BACKLIGHT: 1 range: (0, 7) Backlight: 1 range: (0, 7) scaling mode: Full aspect supported: None, Full, Center, Full aspect 1366x768 (0x48) 70.440MHz -HSync -VSync *current +preferred h: width 1366 start 1414 end 1446 total 1486 skew 0 clock 47.40KHz v: height 768 start 770 end 775 total 790 clock 60.00Hz 1024x768 (0xa3) 65.000MHz -HSync -VSync h: width 1024 start 1048 end 1184 total 1344 skew 0 clock 48.36KHz v: height 768 start 771 end 777 total 806 clock 60.00Hz 800x600 (0xa4) 40.000MHz +HSync +VSync h: width 800 start 840 end 968 total 1056 skew 0 clock 37.88KHz v: height 600 start 601 end 605 total 628 clock 60.32Hz 800x600 (0xa5) 36.000MHz +HSync +VSync h: width 800 start 824 end 896 total 1024 skew 0 clock 35.16KHz v: height 600 start 601 end 603 total 625 clock 56.25Hz 640x480 (0xa6) 25.175MHz -HSync -VSync h: width 640 start 656 end 752 total 800 skew 0 clock 31.47KHz v: height 480 start 490 end 492 total 525 clock 59.94Hz VGA1 disconnected (normal left inverted right x axis y axis) Identifier: 0x43 Timestamp: 34295 Subpixel: unknown Clones: CRTCs: 0 1 Transform: 1.000000 0.000000 0.000000 0.000000 1.000000 0.000000 0.000000 0.000000 1.000000 filter: HDMI1 disconnected (normal left inverted right x axis y axis) Identifier: 0x44 Timestamp: 34295 Subpixel: unknown Clones: CRTCs: 0 1 Transform: 1.000000 0.000000 0.000000 0.000000 1.000000 0.000000 0.000000 0.000000 1.000000 filter: Broadcast RGB: Automatic supported: Automatic, Full, Limited 16:235 audio: auto supported: force-dvi, off, auto, on DP1 disconnected (normal left inverted right x axis y axis) Identifier: 0x45 Timestamp: 34295 Subpixel: unknown Clones: CRTCs: 0 1 Transform: 1.000000 0.000000 0.000000 0.000000 1.000000 0.000000 0.000000 0.000000 1.000000 filter: Broadcast RGB: Automatic supported: Automatic, Full, Limited 16:235 audio: auto supported: force-dvi, off, auto, on VIRTUAL1 disconnected (normal left inverted right x axis y axis) Identifier: 0x46 Timestamp: 34295 Subpixel: no subpixels Clones: CRTCs: 2 Transform: 1.000000 0.000000 0.000000 0.000000 1.000000 0.000000 0.000000 0.000000 1.000000 filter:
Can you repeatedly run: gdbus call --session --dest org.gnome.SettingsDaemon.Power --object-path /org/gnome/SettingsDaemon/Power --method org.gnome.SettingsDaemon.Power.Screen.StepDown And include the full output here?
[conley@styrka ~]$ gdbus call --session --dest org.gnome.SettingsDaemon.Power --object-path /org/gnome/SettingsDaemon/Power --method org.gnome.SettingsDaemon.Power.Screen.StepDown (86,) [conley@styrka ~]$ gdbus call --session --dest org.gnome.SettingsDaemon.Power --object-path /org/gnome/SettingsDaemon/Power --method org.gnome.SettingsDaemon.Power.Screen.StepDown (72,) [conley@styrka ~]$ gdbus call --session --dest org.gnome.SettingsDaemon.Power --object-path /org/gnome/SettingsDaemon/Power --method org.gnome.SettingsDaemon.Power.Screen.StepDown (57,) [conley@styrka ~]$ gdbus call --session --dest org.gnome.SettingsDaemon.Power --object-path /org/gnome/SettingsDaemon/Power --method org.gnome.SettingsDaemon.Power.Screen.StepDown (43,) [conley@styrka ~]$ gdbus call --session --dest org.gnome.SettingsDaemon.Power --object-path /org/gnome/SettingsDaemon/Power --method org.gnome.SettingsDaemon.Power.Screen.StepDown (29,) [conley@styrka ~]$ gdbus call --session --dest org.gnome.SettingsDaemon.Power --object-path /org/gnome/SettingsDaemon/Power --method org.gnome.SettingsDaemon.Power.Screen.StepDown (15,) [conley@styrka ~]$ gdbus call --session --dest org.gnome.SettingsDaemon.Power --object-path /org/gnome/SettingsDaemon/Power --method org.gnome.SettingsDaemon.Power.Screen.StepDown (0,) [conley@styrka ~]$ gdbus call --session --dest org.gnome.SettingsDaemon.Power --object-path /org/gnome/SettingsDaemon/Power --method org.gnome.SettingsDaemon.Power.Screen.StepUp (14,) [conley@styrka ~]$ gdbus call --session --dest org.gnome.SettingsDaemon.Power --object-path /org/gnome/SettingsDaemon/Power --method org.gnome.SettingsDaemon.Power.Screen.StepUp (28,) [conley@styrka ~]$ gdbus call --session --dest org.gnome.SettingsDaemon.Power --object-path /org/gnome/SettingsDaemon/Power --method org.gnome.SettingsDaemon.Power.Screen.StepUp (43,) [conley@styrka ~]$ gdbus call --session --dest org.gnome.SettingsDaemon.Power --object-path /org/gnome/SettingsDaemon/Power --method org.gnome.SettingsDaemon.Power.Screen.StepUp (57,) [conley@styrka ~]$ gdbus call --session --dest org.gnome.SettingsDaemon.Power --object-path /org/gnome/SettingsDaemon/Power --method org.gnome.SettingsDaemon.Power.Screen.StepUp (71,) [conley@styrka ~]$ gdbus call --session --dest org.gnome.SettingsDaemon.Power --object-path /org/gnome/SettingsDaemon/Power --method org.gnome.SettingsDaemon.Power.Screen.StepUp (85,) [conley@styrka ~]$ gdbus call --session --dest org.gnome.SettingsDaemon.Power --object-path /org/gnome/SettingsDaemon/Power --method org.gnome.SettingsDaemon.Power.Screen.StepUp (100,) I went ahead and stepped back up as well. It looks like the discrepancy between 14 and 15 is what causes that small adjustment when going back up from the bottom.
Created attachment 275125 [details] [review] osdWindow: Fix setting a zero-level in osdWindow Commit 7101cc3170bf727aebf918f37debff94ae705c85 caused a small regression insomuch that it checks for a valid "level" but simply using "if (level)" which will be false if level is undefined and if level == 0. Check for not undefined instead.
Review of attachment 275125 [details] [review]: yup
Hopefully, that's the fix for the bug. Reopen if that doesn't fix it.
Attachment 275125 [details] pushed as 2d18b06 - osdWindow: Fix setting a zero-level in osdWindow
*** Bug 727726 has been marked as a duplicate of this bug. ***
It looks like that will fix the issues. However, I'm curious: does the Mutter patch from Bug 710380 (https://bug710380.bugzilla-attachments.gnome.org/attachment.cgi?id=257747) need to add 1 to min-backlight-step like gnome-settings-daemon/plugins/power/gpm-common.c does? I don't know if that will make the steps consistent going up vs down or not. Either way it isn't a huge deal, but it would be a good Gnome Love bug. Should I file a new bug for this?
(In reply to comment #11) > It looks like that will fix the issues. However, I'm curious: does the Mutter > patch from Bug 710380 > (https://bug710380.bugzilla-attachments.gnome.org/attachment.cgi?id=257747) > need to add 1 to min-backlight-step like > gnome-settings-daemon/plugins/power/gpm-common.c does? I don't know if that > will make the steps consistent going up vs down or not. > > Either way it isn't a huge deal, but it would be a good Gnome Love bug. Should > I file a new bug for this? Please do, though it probably needs to be against gnome-settings-daemon.
Submitted as bug 728971. Thanks! :)