After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 727037 - W32: Menu items look thin, while submenu arrows are huge
W32: Menu items look thin, while submenu arrows are huge
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Themes
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2014-03-25 17:49 UTC by LRN
Modified: 2014-04-04 10:13 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
W32: Fix menu item size and submenu arrow size (1.11 KB, patch)
2014-03-25 17:49 UTC, LRN
committed Details | Review
How it looks without the patch (14.07 KB, image/png)
2014-03-25 17:50 UTC, LRN
  Details
How it looks with the patch (13.84 KB, image/png)
2014-03-25 17:50 UTC, LRN
  Details

Description LRN 2014-03-25 17:49:34 UTC
Normal items are thin, but check- and radio-items look ok. Padding should be
added.

Also, default GTK submenu arrows are too big compared to W32's usual ones.
Reducing arrow size will make the difference in shape less glaring.
Comment 1 LRN 2014-03-25 17:49:38 UTC
Created attachment 272888 [details] [review]
W32: Fix menu item size and submenu arrow size
Comment 2 LRN 2014-03-25 17:50:00 UTC
Created attachment 272889 [details]
How it looks without the patch
Comment 3 LRN 2014-03-25 17:50:19 UTC
Created attachment 272890 [details]
How it looks with the patch
Comment 4 Ignacio Casal Quinteiro (nacho) 2014-04-01 07:31:48 UTC
Looks good, although I'd change the comment to:
FIXME: they still have the wrong style though - angle instead of a filled triangle

This way we can easily find in the future there is something there we need to fix.
Comment 5 Matthias Clasen 2014-04-02 00:25:36 UTC
Review of attachment 272888 [details] [review]:

ok, with the change that nacho suggested
Comment 6 LRN 2014-04-04 10:13:40 UTC
Attachment 272888 [details] pushed as e8f0908 - W32: Fix menu item size and submenu arrow size