After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 726970 - Option to "import 0 boxes from system broker"
Option to "import 0 boxes from system broker"
Status: VERIFIED FIXED
Product: gnome-boxes
Classification: Applications
Component: wizard
3.11.x
Other Linux
: Normal normal
: 3.22
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-03-24 14:25 UTC by Michael Catanzaro
Modified: 2016-03-31 13:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Michael Catanzaro 2014-03-24 14:25:28 UTC 
In Boxes 3.11.91, the create new box wizard presents a new option I'd never seen before: import boxes from system broker. I guess that has something to do with libvirt, but I don't know much about that, so it's confusing to me. It might be a good idea to hide this option unless there are actually boxes in the system broker.

Clicking the option takes me to a page that says "Will import 0 boxes from system broker," with the blue Create action suggested in the top-right. Clicking Create just takes me back to the start/overview page with my previously-existing boxes. The Create should have been insensitive, or the page should have been inaccessible.
Comment 1 Zeeshan Ali 2014-03-25 17:34:35 UTC 
Didn't exactly get to test with '0' boxes in system libvirt but I'm pretty sure the fix I just pushed should work.
Comment 2 Christophe Fergeau 2014-03-26 10:30:36 UTC 
I still get the "Import 0 machine from system broker" entry in the wizard. You probably can test this easily with a bogus libvirt URI in
src/libvirt-system-importer.vala:        connection = new GVir.Connection ("qemu+unix:///system");
Comment 3 Zeeshan Ali 2014-03-26 13:27:01 UTC 
(In reply to comment #2)
> I still get the "Import 0 machine from system broker" entry in the wizard. You
> probably can test this easily with a bogus libvirt URI in
> src/libvirt-system-importer.vala:        connection = new GVir.Connection
> ("qemu+unix:///system");

Ouch, I couldn't test because I have 1 box on my system libvirt. I guess I can test with commenting out some code..
Comment 4 Zeeshan Ali 2014-03-26 14:17:36 UTC 
OK, now I believe its really fixed. :)
Comment 5 Christophe Fergeau 2014-03-26 14:23:22 UTC 
Looks good here.