After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 726892 - gnome-autogen.sh: Fix check if stdin is a tty
gnome-autogen.sh: Fix check if stdin is a tty
Status: RESOLVED FIXED
Product: gnome-common
Classification: Core
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: Gnome Common Maintainer(s)
Gnome Common Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-03-22 18:08 UTC by Volker Sobek (weld)
Modified: 2014-03-22 18:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gnome-autogen.sh: Fix check if stdin is a tty (902 bytes, patch)
2014-03-22 18:08 UTC, Volker Sobek (weld) 		committed Details | Review

Description Volker Sobek (weld) 2014-03-22 18:08:52 UTC 
Commit 7f977b021462 introduced a check if stdin is ins't a tty, and
prevent printing terminal codes in this case. But the check was wrong
and always failed.
Comment 1 Volker Sobek (weld) 2014-03-22 18:08:54 UTC 
Created attachment 272649 [details] [review]
gnome-autogen.sh: Fix check if stdin is a tty
Comment 2 Colin Walters 2014-03-22 18:10:10 UTC 
Review of attachment 272649 [details] [review]:

Looks good, thanks!
Comment 3 Colin Walters 2014-03-22 18:10:53 UTC 
Attachment 272649 [details] pushed as d98710d - gnome-autogen.sh: Fix check if stdin is a tty