GNOME Bugzilla – Bug 726829
codecparsers: h264: fix skipping of unsupported SEI messages
Last modified: 2014-05-20 12:24:42 UTC
Hi, this patch fixes skipping of unsupported SEI messages, whereby the payloadSize element shall represent the number of bytes in the payload, excluding any other emulation prevention bytes. In essence, nal_reader_skip_to_next_byte() doesn't make much sense to me, IMHO.
Created attachment 272572 [details] [review] codecparsers: h264: fix skipping of unsupported SEI messages Optimizations are still possible, as we should be aligned to byte boundaries already. Besides, the future of nal_skip_to_next_byte() is yet to be decided. I can kill it altogether, if desired: it's unused now.
In conjunction with patch for bug #685890, this fixes sony-hdr-cx-6-avchd-1080i-3-seconds.mts
This was pushed ages ago. Gwenole, could you please close bugs when you push the patches? commit 1b421808175ab96bf6fd22ccddb49837c152a72c Author: Gwenole Beauchesne <gwenole.beauchesne@intel.com> Date: Fri Mar 21 17:07:19 2014 +0100 codecparsers: h264: fix skipping of unsupported SEI messages. The payloadSize does not account for emulation prevention bytes. So, just use nal_reader_skip() for skipping payload_size bits. It should be possible to further optimize this code since the NAL reader shall be aligned to byte boundary already. Kill the now unused nal_reader_skip_to_next_byte() function. https://bugzilla.gnome.org/show_bug.cgi?id=726829 Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
Hmm, sorry, either I missed those, or I closed another bug instead. I will have to check. :)