After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 726776 - Incorrect uri parameter in Soup message in handle_playlist function
Incorrect uri parameter in Soup message in handle_playlist function
Status: RESOLVED FIXED
Product: rygel
Classification: Applications
Component: librygel-renderer
0.21.x
Other Linux
: Normal normal
: ---
Assigned To: rygel-maint
rygel-maint
Depends on:
Blocks:
 
 
Reported: 2014-03-20 14:27 UTC by Dario Russo
Modified: 2014-03-20 19:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
renderer: Fix URI handling (1.08 KB, patch)
2014-03-20 19:02 UTC, Jens Georg
committed Details | Review

Description Dario Russo 2014-03-20 14:27:07 UTC
During playlist handling, there is an assert (or more troubles) due to unset uri string in the soup message, as controller.uri is set after the Soup.Message creation:

Rygel-av-transport.vala:697

private async void handle_playlist (ServiceAction action,
                                        string uri,
                                        string metadata,
                                        string mime,
                                        string features) {
        var message = new Message ("GET", this.controller.uri);

It should be:

        var message = new Message ("GET", uri);

Rebuild librygel-renderer with this change, and playlists seem to work fine.
Comment 1 Jens Georg 2014-03-20 19:02:49 UTC
Created attachment 272515 [details] [review]
renderer: Fix URI handling

Signed-off-by: Jens Georg <mail@jensge.org>
Comment 2 Jens Georg 2014-03-20 19:07:24 UTC
Attachment 272515 [details] pushed as a00b362 - renderer: Fix URI handling