GNOME Bugzilla – Bug 726760
app picker keynav: focus escapes from app folders
Last modified: 2014-05-27 17:53:01 UTC
when I keynav around the app picker, I can open a folder by hitting enter. The folder opens and the focus is inside it. Escape closes the folder, and I can move the focus around in it using the arrow keys. Left/Right/Up arrows just stop when I hit the limits of the app folder. But the down arrow makes the focus escape from the folder in a way that feels unintended. I'm left with the focus outside the open app folder and no way to either get the focus back in the folder, or close the folder (by keynav, at least).
Created attachment 277081 [details] [review] viewSelector: Don't re-navigate into the active page Starting keynav into the active page is handled from a key-press handler on the stage, however we should not "start" keynav when we are already navigating elsewhere - the latter can happen when keynav fails (for instance because the focus is trapped inside an open app folder or at the end of the dash), and the event bubbles up to the stage. So make sure to only handle the event to actually start keynav, to not interfere with the normal navigation handling. Thanks to Carlos Soriano <carlos.soriano89@gmail.com> for the debugging footwork.
Review of attachment 277081 [details] [review]: One thing I experienced with this patch is that, if you are in the frequent view, go down until the view selector. Choose all. Try to move focus to the page. You can't. I think this is something that when this bug (current one we are trying to solve) is present it doesn't happens, since we always ended giving focus to the active page. But I would say this is another bug than now we are hitting due to fixing this, so not related to this patch.
So imho, fine to push it.
(In reply to comment #2) > Review of attachment 277081 [details] [review]: > > One thing I experienced with this patch is that, if you are in the frequent > view, > go down until the view selector. Choose all. Try to move focus > to the page. You can't. Mmmh, interesting. I can reproduce this with up-arrow, tab/shift-tab work as expected. Without the patch, down-arrow does work (obviously), but that's actually a bug - arrow keys are not supposed to wrap around. Note that up-arrow will work when the last page is selected. In any case, it's unrelated to this patch.
(In reply to comment #4) > (In reply to comment #2) > > Review of attachment 277081 [details] [review] [details]: > > > > One thing I experienced with this patch is that, if you are in the frequent > > view, > > go down until the view selector. Choose all. Try to move focus > > to the page. You can't. > > Mmmh, interesting. I can reproduce this with up-arrow, tab/shift-tab work as > expected. Without the patch, down-arrow does work (obviously), but that's > actually a bug - arrow keys are not supposed to wrap around. > > Note that up-arrow will work when the last page is selected. In any case, it's > unrelated to this patch. Right
Attachment 277081 [details] pushed as c228a9a - viewSelector: Don't re-navigate into the active page