After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 726721 - Some tracks are identified as 'MediaVideo' and crash in various places
Some tracks are identified as 'MediaVideo' and crash in various places
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
3.11.x
Other Linux
: High critical
: ---
Assigned To: Vadim Rutkovsky
gnome-music-maint
Depends on:
Blocks:
 
 
Reported: 2014-03-19 15:29 UTC by Torsten Scholak
Modified: 2014-04-21 12:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Use 'Untitled Artist' and "Untitled Album" in searchbar (1.65 KB, patch)
2014-03-21 12:23 UTC, Vadim Rutkovsky
none Details | Review

Description Torsten Scholak 2014-03-19 15:29:10 UTC
I get this error when I try to search for artists in the artist pane.

Traceback (most recent call last):
  • File "/usr/lib64/python3.2/site-packages/gnomemusic/searchbar.py", line 32 in set_view_filter
    artist = media.get_artist()
AttributeError: 'MediaVideo' object has no attribute 'get_artist'

Comment 1 Torsten Scholak 2014-03-19 15:32:00 UTC
sorry, that was incorrect. I don't even need to issue a search. It is enough to visit the songs pane.
Comment 2 Vadim Rutkovsky 2014-03-21 12:23:19 UTC
Created attachment 272557 [details] [review]
Use 'Untitled Artist' and "Untitled Album" in searchbar
Comment 3 Vadim Rutkovsky 2014-03-21 14:37:43 UTC
Fixed in https://git.gnome.org/browse/gnome-music/commit/?id=9a1b515
Comment 4 Torsten Scholak 2014-03-27 05:12:38 UTC
Hmm, I'm not so sure about that.

I just got the same error again:
Traceback (most recent call last):
  • File "/usr/lib64/python3.2/site-packages/gnomemusic/searchbar.py", line 34 in set_view_filter
    if media.get_artist() is not None:
AttributeError: 'MediaVideo' object has no attribute 'get_artist'

I have the newest version of gnome-music.
Comment 5 Vadim Rutkovsky 2014-03-27 09:03:47 UTC
That looks like the same error message but in different place. Could you identify which track is causing this?
Comment 6 Torsten Scholak 2014-03-27 14:34:55 UTC
It's hard to reproduce the error; I am limited also by bug 726459.
I am unable to pinpoint the cause of the problem.
However, I made an 18 min long screencast that shows the effect of bug 726459 several times and the error referred to here at the very end. I provoke it by switching tabs while playing the same piece of music over and over on repeat.

https://www.dropbox.com/s/traq6nhmzrjy2m9/Screencast%20from%2027-03-14%2010%3A00%3A59%20AM.webm?m=
Comment 7 Torsten Scholak 2014-03-27 14:39:21 UTC
for some reason, the quality of the screencast is much better if it's downloaded.
Comment 8 Vadim Rutkovsky 2014-03-27 21:22:26 UTC
Pushed https://git.gnome.org/browse/gnome-music/commit/?id=b5092d6 to master
Comment 9 Torsten Scholak 2014-03-28 03:19:00 UTC
I really hate to bother everyone again with this...
I bet I am the only person with audio files that are also videos...

It seems these m4r files cause fatal errors also in other circumstances.

I got the following error while clicking on one of them in the Album track list in the Artists view:

Traceback (most recent call last):
  • File "/usr/lib64/python3.2/site-packages/gnomemusic/mpris.py", line 118 in _on_current_changed
    'Metadata': dbus.Dictionary(self._get_metadata(),
  • File "/usr/lib64/python3.2/site-packages/gnomemusic/mpris.py", line 80 in _get_metadata
    'xesam:trackNumber': media.get_track_number(),
AttributeError: 'MediaVideo' object has no attribute 'get_track_number'

The same exception is raised in selection mode and in the Songs view when clicked on one of the tracks.
Comment 10 Vadim Rutkovsky 2014-03-28 12:48:55 UTC
Commit https://git.gnome.org/browse/gnome-music/commit/?id=2142ff6 should fix the crash and https://git.gnome.org/browse/gnome-music/commit/?id=995bfd6 should display an artist for this track (or Unknown Artist).

Please reopen if the app crashes in any other place for this file or MediaVideo object
Comment 11 Torsten Scholak 2014-03-29 14:38:52 UTC
I updated gnome-music and tested the patch.
I regret to report that it does not solve the issues.
I now get:

Traceback (most recent call last):
  • File "/usr/lib64/python3.2/site-packages/gnomemusic/mpris.py", line 177 in _on_current_changed
    'Metadata': dbus.Dictionary(self._get_metadata(),
  • File "/usr/lib64/python3.2/site-packages/gnomemusic/mpris.py", line 92 in _get_metadata
    trackNumber = media.get_track_number()
AttributeError: 'MediaVideo' object has no attribute 'get_track_number'

Comment 12 Vadim Rutkovsky 2014-03-29 20:09:37 UTC
Okay, thanks, in commit https://git.gnome.org/browse/gnome-music/commit/?id=c42c36c we're skipping any exceptions, occurring in this modules. Please reopen the bug if something related to MediaVideo object crashes the app.
Comment 13 Torsten Scholak 2014-03-30 19:50:02 UTC
there we go again:

Traceback (most recent call last):
  • File "/usr/lib64/python3.2/site-packages/gnomemusic/widgets.py", line 612 in track_selected
    self.player.set_playing(True)
  • File "/usr/lib64/python3.2/site-packages/gnomemusic/player.py", line 340 in set_playing
    self.play()
  • File "/usr/lib64/python3.2/site-packages/gnomemusic/player.py", line 391 in play
    self.load(media)
  • File "/usr/lib64/python3.2/site-packages/gnomemusic/player.py", line 362 in load
    if media.get_artist() is not None:
AttributeError: 'MediaVideo' object has no attribute 'get_artist'

and:

Traceback (most recent call last):
  File "/usr/lib64/python3.2/site-packages/gnomemusic/view.py", line 434, in _on_item_activated
    self.player.set_playing(True)
  File "/usr/lib64/python3.2/site-packages/gnomemusic/player.py", line 340, in set_playing
    self.play()
  File "/usr/lib64/python3.2/site-packages/gnomemusic/player.py", line 391, in play
    self.load(media)
  File "/usr/lib64/python3.2/site-packages/gnomemusic/player.py", line 362, in load
    if media.get_artist() is not None:
AttributeError: 'MediaVideo' object has no attribute 'get_artist'
Comment 14 Vadim Rutkovsky 2014-03-31 11:46:04 UTC
https://git.gnome.org/browse/gnome-music/commit/?id=b252ec9 should take care of that
Comment 15 Torsten Scholak 2014-04-21 01:43:12 UTC
don't know if related, but, yeah, have a look:

Traceback (most recent call last):

(gnome-music:24973): GLib-GIO-CRITICAL **: g_file_get_parent: assertion 'G_IS_FILE (file)' failed
  • File "/usr/lib64/python3.2/site-packages/gnomemusic/__init__.py", line 44 in wrapped
    retval = fn(*v, **k)
  • File "/usr/lib64/python3.2/site-packages/gnomemusic/view.py", line 453 in _on_item_activated
    self.player.set_playing(True)
  • File "/usr/lib64/python3.2/site-packages/gnomemusic/__init__.py", line 44 in wrapped
    retval = fn(*v, **k)
  • File "/usr/lib64/python3.2/site-packages/gnomemusic/player.py", line 361 in set_playing
    self.play()
  • File "/usr/lib64/python3.2/site-packages/gnomemusic/__init__.py", line 44 in wrapped
    retval = fn(*v, **k)
  • File "/usr/lib64/python3.2/site-packages/gnomemusic/player.py", line 425 in play
    self.load(media)
  • File "/usr/lib64/python3.2/site-packages/gnomemusic/__init__.py", line 44 in wrapped
    retval = fn(*v, **k)
  • File "/usr/lib64/python3.2/site-packages/gnomemusic/player.py", line 381 in load
    assert media.get_artist() is not None AssertionError
It is not at all clear what caused the error. I switched back focus to gnome-music after hours of inactivity shortly before it locked up and seconds later crashed.

Comment 16 Vadim Rutkovsky 2014-04-21 09:48:56 UTC
This error is not related to the original bug report. Please open a new issue for that
Comment 17 Torsten Scholak 2014-04-21 12:59:06 UTC
Ok, I do once I find a pattern. So far it's an isolated incident.