After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 726707 - Cannot build gvfs on FreeBSD if libbluray is installed
Cannot build gvfs on FreeBSD if libbluray is installed
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: build
git master
Other FreeBSD
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2014-03-19 13:29 UTC by Ting-Wei Lan
Modified: 2014-03-27 12:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
use nl_langinfo constants conditionally (1.08 KB, patch)
2014-03-20 15:58 UTC, Ondrej Holy 		none Details | Review
fix building on BSD (1.04 KB, patch)
2014-03-20 17:07 UTC, Ondrej Holy 		none Details | Review
use nl_langinfo constants conditionally (1.98 KB, patch)
2014-03-21 12:45 UTC, Ondrej Holy 		committed Details | Review

Description Ting-Wei Lan 2014-03-19 13:29:20 UTC 
The use of _NL_ADDRESS_LANG_TERM and _NL_ADDRESS_COUNTRY_AB3 in common/gvfsmountinfo.c are not portable. It cause the build on FreeBSD to fail with the following error:

gvfsmountinfo.c:434:23: error: use of undeclared identifier '_NL_ADDRESS_LANG_TERM'
gvfsmountinfo.c:437:27: error: use of undeclared identifier '_NL_ADDRESS_COUNTRY_AB3'
Comment 1 Ondrej Holy 2014-03-20 15:58:54 UTC 
Created attachment 272494 [details] [review]
use nl_langinfo constants conditionally
Comment 2 Ting-Wei Lan 2014-03-20 16:06:18 UTC 
_NL_ADDRESS_LANG_TERM and _NL_ADDRESS_COUNTRY_AB3 are enums, not macros.
Comment 3 Ondrej Holy 2014-03-20 17:05:41 UTC 
Thanks, good point, but how we can check the enums? It looks like AC_CHECK_DECL doesn't work for enums...
Comment 4 Ondrej Holy 2014-03-20 17:07:13 UTC 
Created attachment 272503 [details] [review]
fix building on BSD

This enums isn't supported generally in BSDs? Or it depends on version of libc?
Comment 5 Ting-Wei Lan 2014-03-20 17:13:45 UTC 
These enums are GNU extensions, so most BSDs do not support them.
Comment 6 Ondrej Holy 2014-03-21 12:45:36 UTC 
Created attachment 272558 [details] [review]
use nl_langinfo constants conditionally

AC_CHECK_DECL looks like working for enums, could you prove it please?
Comment 7 Ting-Wei Lan 2014-03-22 04:00:05 UTC 
(In reply to comment #6)
> Created an attachment (id=272558) [details] [review]
> use nl_langinfo constants conditionally
> 
> AC_CHECK_DECL looks like working for enums, could you prove it please?

gvfs can be successfully built on FreeBSD using this patch.
Comment 8 Ross Lagerwall 2014-03-24 07:40:44 UTC 
Review of attachment 272558 [details] [review]:

Looks good!
Comment 9 Ondrej Holy 2014-03-27 12:57:16 UTC 
Comment on attachment 272558 [details] [review]
use nl_langinfo constants conditionally

commit a77cdbac08ca1ff17aeba2323a610a61101387db