After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 726641 - rtspconnection: connection_poll() not working correctly
rtspconnection: connection_poll() not working correctly
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 1.3.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-03-18 15:45 UTC by Ognyan Tonchev (redstar_)
Modified: 2014-03-24 11:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
rtspconnection: Fix connection_poll() (3.30 KB, patch)
2014-03-18 15:47 UTC, Ognyan Tonchev (redstar_) 		none Details | Review

Description Ognyan Tonchev (redstar_) 2014-03-18 15:45:39 UTC 
gst_rtsp_connection_poll() is not working correctly. It will never block even if set to do so and also it always checks if socket is both readable and writeable regardless of input argument.
Comment 1 Ognyan Tonchev (redstar_) 2014-03-18 15:47:06 UTC 
Created attachment 272290 [details] [review]
rtspconnection: Fix connection_poll()

* Only check for conditions we are interested in.
* Makes no sense to specify G_IO_ERR and G_IO_HUP in condition, they will always be reported if they are true.
* Do not create timed source if timeout is NULL.
* Correctly wait for sources to be dispatched, context_iteration() is not guaranteed to always block even if set to do so.
Comment 2 Wim Taymans 2014-03-24 11:44:17 UTC 
commit e0af857445bd42205e471907b1c899699c03cc94
Author: Ognyan Tonchev <otonchev@gmail.com>
Date:   Sun Mar 16 17:06:02 2014 +0100

    rtspconnection: Fix connection_poll()
    
    * Only check for conditions we are interested in.
    * Makes no sense to specify G_IO_ERR and G_IO_HUP in condition, they
      will always be reported if they are true.
    * Do not create timed source if timeout is NULL.
    * Correctly wait for sources to be dispatched, context_iteration() is
      not guaranteed to always block even if set to do so.
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=726641