After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 726461 - collectpads: should send the seek events to the peers of its sink pads, as they can be flushing
collectpads: should send the seek events to the peers of its sink pads, as th...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 1.3.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 724705
 
 
Reported: 2014-03-16 16:28 UTC by Mathieu Duponchelle
Modified: 2014-03-16 16:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fixes the reported issue (993 bytes, patch)
2014-03-16 16:34 UTC, Mathieu Duponchelle 		committed Details | Review

Description Mathieu Duponchelle 2014-03-16 16:28:37 UTC 
A sinkpad might still be flushing from a previous flushing seek, and we want to propagate the seek anyway, so sending to the peer bypasses core checking for flushing in push_event.

The fix is attached next
Comment 1 Mathieu Duponchelle 2014-03-16 16:34:36 UTC 
Created attachment 272073 [details] [review]
fixes the reported issue
Comment 2 Sebastian Dröge (slomo) 2014-03-16 16:48:11 UTC 
commit 595481c75903e8efdffbcc26a99b5743438b9a66
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Sun Mar 16 17:47:06 2014 +0100

    collectpads: Unref peer pad

commit c86e53ab77bbd7feb456f9e2fb498cf4de6ef5ec
Author: Mathieu Duponchelle <mduponchelle1@gmail.com>
Date:   Sun Feb 16 20:35:09 2014 +0100

    collectpads: Forward seek events to the peer directly
    
    Taken from the adder seek handling code.
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=726461