After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 726333 - priority argument dropped from Mainloop.idle_add
priority argument dropped from Mainloop.idle_add
Status: RESOLVED FIXED
Product: gjs
Classification: Bindings
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gjs-maint
gjs-maint
Depends on:
Blocks:
 
 
Reported: 2014-03-14 12:22 UTC by Daniel Drake
Modified: 2014-06-15 14:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
mainloop: restore priority arguments to *_add() calls (2.22 KB, patch)
2014-06-15 14:08 UTC, Giovanni Campagna 		committed Details | Review

Description Daniel Drake 2014-03-14 12:22:09 UTC 
Commit b5e467d89aea43a8e32a1138d232c8a32e6b0785 quietly dropped the priority argument from idle_add, which caused a regression in gnome-shell as it needed to queue an idle task at higher priority: https://bugzilla.gnome.org/show_bug.cgi?id=585500

If this was unintentionally dropped, can it come back? It can be useful sometimes.
Comment 1 Giovanni Campagna 2014-06-15 14:08:57 UTC 
Created attachment 278486 [details] [review]
mainloop: restore priority arguments to *_add() calls

The original Mainloop API had an optional priority argument at the
end of idle_add(), timeout_add() and timeout_add_seconds(). Restore
support for it.
Comment 2 Jasper St. Pierre (not reading bugmail) 2014-06-15 14:38:23 UTC 
Review of attachment 278486 [details] [review]:

OK.
Comment 3 Giovanni Campagna 2014-06-15 14:40:52 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.