After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 726040 - networkaddress: fix parsing of uri with @ after authority
networkaddress: fix parsing of uri with @ after authority
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
2.39.x
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
: 725457 (view as bug list)
Depends on:
Blocks: 725457
 
 
Reported: 2014-03-10 15:45 UTC by Wim Taymans
Modified: 2014-04-25 22:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
possible patch (2.16 KB, patch)
2014-03-10 15:45 UTC, Wim Taymans 		committed Details | Review

Description Wim Taymans 2014-03-10 15:45:51 UTC 
Created attachment 271446 [details] [review]
possible patch

gnetworkaddress assumes that an @ sign in the uri is always part of the authority and proceeds with parsing the userinfo before it, which might then fail.

Attached patch checks only parses the userinfo if the @ sign was part of the authority.
Comment 1 Dan Winship 2014-03-16 15:56:02 UTC 
Comment on attachment 271446 [details] [review]
possible patch

ok
Comment 2 Wim Taymans 2014-04-02 15:09:10 UTC 
Can you push it? I can't do that.
Comment 3 Dan Winship 2014-04-02 15:23:31 UTC 
done
Comment 4 Sebastian Dröge (slomo) 2014-04-02 20:55:19 UTC 
*** Bug 725457 has been marked as a duplicate of this bug. ***
Comment 5 Nicola 2014-04-21 13:43:41 UTC 
can this fix be pushed to the 2.40 branch and so be available in the next minor update (2.40.1) instead of 2.42?
Comment 6 Dan Winship 2014-04-25 22:29:18 UTC 
(In reply to comment #5)
> can this fix be pushed to the 2.40 branch

done