After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 726037 - Add G_PARAM_READWRITE value to the GParamFlags enumeration
Add G_PARAM_READWRITE value to the GParamFlags enumeration
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gobject
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2014-03-10 15:06 UTC by Emmanuele Bassi (:ebassi)
Modified: 2014-11-10 22:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gparam: Annotate G_PARAM_READWRITE (761 bytes, patch)
2014-03-10 15:06 UTC, Emmanuele Bassi (:ebassi) 		none Details | Review
gparam: Add G_PARAM_READWRITE to GParamFlags (1.77 KB, patch)
2014-03-10 15:18 UTC, Emmanuele Bassi (:ebassi) 		committed Details | Review
docs: Update GParamFlags docs. (878 bytes, patch)
2014-05-23 20:56 UTC, Volker Sobek (weld) 		committed Details | Review

Description Emmanuele Bassi (:ebassi) 2014-03-10 15:06:28 UTC 
The introspection scanner cannot resolve the G_PARAM_READWRITE #define, so we need to help it out ourselves.
Comment 1 Emmanuele Bassi (:ebassi) 2014-03-10 15:06:30 UTC 
Created attachment 271435 [details] [review]
gparam: Annotate G_PARAM_READWRITE

This avoids having to re-define it inside language bindings.
Comment 2 Emmanuele Bassi (:ebassi) 2014-03-10 15:12:07 UTC 
this is less useful than I hoped, since it generates a GObject.PARAM_READWRITE symbol outside of the GObject.ParamFlags type. it would be better to just get rid of the #define and add G_PARAM_READWRITE to the GParamFlags enumeration.
Comment 3 Emmanuele Bassi (:ebassi) 2014-03-10 15:18:13 UTC 
Created attachment 271437 [details] [review]
gparam: Add G_PARAM_READWRITE to GParamFlags

Using a #define for an enumeration value buys us nothing, and it's
mostly historical baggage that makes binding GObject needlessly
complicated.
Comment 4 Allison Karlitskaya (desrt) 2014-03-10 15:22:25 UTC 
Review of attachment 271437 [details] [review]:

Looks fine, but can it wait?  We've been bitten before by bizarre unintended effects caused by moving things between enums and defines, and we are past API freeze at this point...
Comment 5 Emmanuele Bassi (:ebassi) 2014-03-10 15:25:44 UTC 
to be fair, I don't see any reason why this would break anything, but if you feel more comfortable with punting it for 2.42 that sounds fine by me.
Comment 6 Emmanuele Bassi (:ebassi) 2014-04-10 19:27:43 UTC 
freeze past, master has been branched.

Attachment 271437 [details] pushed as 6c39524 - gparam: Add G_PARAM_READWRITE to GParamFlags
Comment 7 Volker Sobek (weld) 2014-05-23 20:56:06 UTC 
Created attachment 277085 [details] [review]
docs: Update GParamFlags docs.

Remove reference to G_PARAM_READWRITE from GParamFlags' description,
since commit 6c395244a5db added G_PARAM_READWRITE to GParamFlags.
Comment 8 Volker Sobek (weld) 2014-05-23 20:56:51 UTC 
Found this little remainder ^.
Comment 9 Emmanuele Bassi (:ebassi) 2014-11-10 15:34:22 UTC 
Review of attachment 277085 [details] [review]:

looks good.
Comment 10 Volker Sobek (weld) 2014-11-10 22:27:09 UTC 
Attachment 277085 [details] pushed as 1edd463 - docs: Update GParamFlags docs.