GNOME Bugzilla – Bug 726025
omxvideodec: separate the buffer pool from the decoder
Last modified: 2014-07-23 08:21:02 UTC
Created attachment 271411 [details] [review] Patch. No intended functional change, but the buffer pool should be usable by all components, not only the decoder.
Comment on attachment 271411 [details] [review] Patch. Looks good, thanks :) Are you planning to provide a patch for the video encoder to use that? Might make sense to also make the GstOMXMemory public in the header, the element code might need it later. And this does not apply cleanly currently. Can you provide a patch that applies cleanly again git master?
commit e9b7dc230b83bed63fbd15409165071f635207da Author: Sebastian Dröge <sebastian@centricular.com> Date: Wed Mar 12 12:42:23 2014 +0100 omxbufferpool: Fix header include guard commit 325c90f99d8a3274fe112117a2485b69c74c1915 Author: Christian König <christian.koenig@amd.com> Date: Wed Mar 5 11:41:02 2014 +0100 omxvideodec: separate the buffer pool from the decoder https://bugzilla.gnome.org/show_bug.cgi?id=726025
(In reply to comment #1) > (From update of attachment 271411 [details] [review]) > Looks good, thanks :) Are you planning to provide a patch for the video encoder > to use that? Yes, but this probably will take a while until I got it stable. > And this does not apply cleanly currently. Can you provide a patch that applies > cleanly again git master? Oh, sorry it probably needed one of the other patches first. Need to better note the dependency between the patches the next time.