After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 725862 - buffer: invert BUFFER_FLAG_TAG_MEMORY ?
buffer: invert BUFFER_FLAG_TAG_MEMORY ?
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
unspecified
Other All
: Normal minor
: 1.3.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-03-06 23:10 UTC by Tim-Philipp Müller
Modified: 2014-03-08 14:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Tim-Philipp Müller 2014-03-06 23:10:38 UTC 
I think we should invert the meaning of GST_BUFFER_FLAG_TAG_MEMORY so that it is *set* when memory removed/added to a buffer. Otherwise it pollutes the 'flags' output in e.g. fakesink and identity, and it also seems more natural to set a flag to indicate something rather than clear it. Is there any reason why it's done like it's done now, or can it be changed?
Comment 1 Sebastian Dröge (slomo) 2014-03-08 14:05:51 UTC 
This was fixed now: http://cgit.freedesktop.org/gstreamer/gstreamer/commit/?id=313f01ab79c9377c05bc1ca4f9c24a5cd522c2be