Created attachment 271115 [details] [review]
Lightbox: complete radial effect for modal dialogs

Rework the radial effect to use similar code to MetaBackground,
and adjust parameters to make it more noticeable.

Review of attachment 271115 [details] [review]:

Code looks good to me, just some minor comments. 

Make sure to get a design ack before pushing.

::: js/ui/lightbox.js
@@ +166,2 @@
             Tweener.addTween(this.actor,
+                             { brightness: 0.8,

Use a constant instead of a magic number.

@@ +166,3 @@
             Tweener.addTween(this.actor,
+                             { brightness: 0.8,
+                               vignetteSharpness: 0.7,

Same here.

::: src/shell-glsl-quad.c
@@ +161,3 @@
+
+int
+shell_glsl_quad_get_uniform_location (ShellGLSLQuad *quad,

Adding a doc commnt wouldm't hurt even for a trival function like this.

Created attachment 271452 [details] [review]
Lightbox: complete radial effect for modal dialogs

Rework the radial effect to use similar code to MetaBackground,
and adjust parameters to make it more noticeable.

Created attachment 271453 [details]
Screenshot after the patch

Review of attachment 271452 [details] [review]:

Looks good.

Waiting for final design approval.

(In reply to comment #6)
> Waiting for final design approval.

Looks good to me and Jakub!

Attachment 271452 [details] pushed as fc4bc52 - Lightbox: complete radial effect for modal dialogs