After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 725659 - wininetsrc: "iradio-mode" to default to TRUE
wininetsrc: "iradio-mode" to default to TRUE
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
unspecified
Other All
: Normal normal
: 1.3.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-03-04 15:29 UTC by Andres Gomez
Modified: 2014-03-05 19:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
wininet: "iradio-mode" property defaults to TRUE (1.36 KB, patch)
2014-03-04 15:29 UTC, Andres Gomez 		committed Details | Review

Description Andres Gomez 2014-03-04 15:29:15 UTC 
As per discussed in bug 725383, it would make more sense to default to TRUE
for the "iradio-mode" property as other HTTP source elements are already
doing (souphttpsrc, neonhttpsrc, ...), and ignore not understood headers,
if so.

Also, uridecodebin won't automatically set this property to TRUE any more
so it makes sense to change it also in wininetsrc.
Comment 1 Andres Gomez 2014-03-04 15:29:17 UTC 
Created attachment 270911 [details] [review]
wininet: "iradio-mode" property defaults to TRUE

As per discussed in bug #725383, it doesn't make much sense to default
to FALSE in the "iradio-mode" property. Better, let's sent the header
by default and just ignore headers that are not understood, if so.
Comment 2 Sebastian Dröge (slomo) 2014-03-05 19:29:04 UTC 
Not that this plugin is ported to 1.0... but let's do that change now to not forget it later. If anybody ever ports it to 1.0.

commit 2129b4739b642bf1904a0f92e288bb5cc9e21096
Author: Andres Gomez <agomez@igalia.com>
Date:   Tue Mar 4 17:25:23 2014 +0200

    wininet: "iradio-mode" property defaults to TRUE
    
    As per discussed in bug #725383, it doesn't make much sense to default
    to FALSE in the "iradio-mode" property. Better, let's sent the header
    by default and just ignore headers that are not understood, if so.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=725659