GNOME Bugzilla – Bug 725606
calendar: Grab key focus again after changing day
Last modified: 2014-03-07 18:31:52 UTC
When the user changes the active day by mouse click or keyboard focus plus key press on a day in the grid, always move the key focus to the newly activated day. This fixes two issues: * The keyboard focus was lost after rebuilding the calendar in case the user clicked on day outside of the current month - this issue already exists in the 3.10 branch. * The keyboard focus was no longer set at all when clicking on a day with the mouse - this was caused by the most recent commits to calendar.js and is not present in the 3.10 branch.
Created attachment 270831 [details] [review] calendar: Grab key focus again after changing day
Created attachment 271023 [details] [review] calendar: Grab key focus when user changes day When the user changes the active day by mouse click or keyboard focus plus key press on a day in the grid, always move the key focus to the newly activated day. Apparently this was working before (commit 31478e9fb441), but was broken again along the way.
Created attachment 271226 [details] [review] calendar: Grab key focus when user changes day When the user changes the active day by mouse click or keyboard focus plus key press on a day in the grid, always move the keyboard focus to the newly activated day. This basically restores functionality that was introduced in commit 31478e9fb441 but got lost again in the re-factoring in commit cc4659f5c697.
Updated the commit message to mention the exact commits in which this functionality was introduced and got lost again.
Review of attachment 271226 [details] [review]: Please initialize the variable on _init(). With that, looks good
Attachment 271226 [details] pushed as 257e1f3 - calendar: Grab key focus when user changes day
Notice that i pushed the corrected patch, I thought git bz would see this.