After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 725513 - Some tests fail to build on W32
Some tests fail to build on W32
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: win32
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-win32 maintainers
gtk-win32 maintainers
Depends on:
Blocks:
 
 
Reported: 2014-03-02 19:10 UTC by LRN
Modified: 2014-08-04 06:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix tests to compile again - add missing headers to W32, call correct process-id-getting function (2.85 KB, patch)
2014-03-02 19:10 UTC, LRN 		none Details | Review
Fix tests to compile again - add missing headers to W32, call correct process-id-getting function (2.85 KB, patch)
2014-04-21 17:12 UTC, LRN 		committed Details | Review

Description LRN 2014-03-02 19:10:06 UTC 
Some headers are not included, and getpid() is not a valid function.
Comment 1 LRN 2014-03-02 19:10:10 UTC 
Created attachment 270713 [details] [review]
Fix tests to compile again - add missing headers to W32, call correct process-id-getting function
Comment 2 LRN 2014-04-21 17:12:14 UTC 
Created attachment 274821 [details] [review]
Fix tests to compile again - add missing headers to W32, call  correct process-id-getting function

v2: same thing, just attached with git bz
Comment 3 Ignacio Casal Quinteiro (nacho) 2014-07-28 10:42:20 UTC 
Review of attachment 274821 [details] [review]:

I'd say go ahead.
Comment 4 LRN 2014-08-02 12:41:55 UTC 
Attachment 274821 [details] pushed as 4f73487 - Fix tests to compile again - add missing headers to W32, call  correct process-id-getting function
Comment 5 Fan, Chun-wei 2014-08-04 06:02:17 UTC 
Review of attachment 274821 [details] [review]:

Hi,

Just some notes here on my side...

There were some work some time ago[1][2] about only including unistd.h on non-Windows, so I guess it is my fault on the test sources that I should test-build them with the /W3 (or so, warning level #3) so that I could see the C4013 warnings (i.e. implcit declaration of ...) so that a warning is issued for those functions, so that the correct Windows headers are included.  Sorry 'bout it.

For win32-streams.c, would it be preferred that we include process.h for using getpid() instead?

[1]: https://git.gnome.org/browse/glib/commit/?id=d262b6fe0ca851a47fede2e624cec4aa041f2f14

[2]: https://git.gnome.org/browse/glib/commit/?id=f4931142806556123ce75dcf8b84e60dc7cd4e3c

With blessings.