After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 725510 - uistate: Removed unneeded ui state SETTINGS
uistate: Removed unneeded ui state SETTINGS
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: 3.22
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-03-02 18:43 UTC by Lasse Schuirmann
Modified: 2016-03-31 13:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
uistate: Removed unneeded ui state SETTINGS. (622 bytes, patch)
2014-03-02 18:43 UTC, Lasse Schuirmann 		committed Details | Review

Description Lasse Schuirmann 2014-03-02 18:43:12 UTC 
In src/ui.vala in the UIState enum is a member named SETTINGS. This member is
never used in the whole program, forgotten and unchanged since 2011.
Comment 1 Lasse Schuirmann 2014-03-02 18:43:14 UTC 
Created attachment 270708 [details] [review]
uistate: Removed unneeded ui state SETTINGS.

The SETTINGS in the UIState enum was created in 2011 and forgotten since then.
Comment 2 Zeeshan Ali 2014-03-02 18:58:00 UTC 
I think a separate bug for this minor cleanup patch is a bit of an overkill, you could have added it to the bug where we identified the need for it. No issue really, just for future reference. :)
Comment 3 Zeeshan Ali 2014-03-02 18:59:02 UTC 
Review of attachment 270708 [details] [review]:

nitpick: To keep the commit log summary line short, simple phrases without '.' at the end is good enough.
Comment 4 Zeeshan Ali 2014-03-02 19:02:29 UTC 
Thanks for the patch, I pushed it with some minor changes to commit log (remember the description lines shouldn't exceed 74 characters.