After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 725135 - Add support to configure display border
Add support to configure display border
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Display
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: Debarshi Ray
Control-Center Maintainers
Depends on: 725133 751814
Blocks:
 
 
Reported: 2014-02-25 11:44 UTC by Nikhil Mahale
Modified: 2016-04-05 17:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
display: Add option to enable and disable overscan compensation (2.63 KB, patch)
2015-06-30 22:03 UTC, Cosimo Cecchi
reviewed Details | Review
display: Add option to enable and disable overscan compensation (2.69 KB, patch)
2015-07-02 01:17 UTC, Cosimo Cecchi
none Details | Review
screenshot (1.45 MB, image/png)
2015-07-02 01:19 UTC, Cosimo Cecchi
  Details
display: add option to enable and disable overscan compensation (3.32 KB, patch)
2016-04-03 18:13 UTC, Cosimo Cecchi
none Details | Review
screenshot (97.17 KB, image/png)
2016-04-03 18:14 UTC, Cosimo Cecchi
  Details
display: add option to enable and disable overscan compensation (2.76 KB, patch)
2016-04-05 04:46 UTC, Cosimo Cecchi
none Details | Review
display: add option to enable and disable overscan compensation (8.04 KB, patch)
2016-04-05 15:41 UTC, Cosimo Cecchi
committed Details | Review

Description Nikhil Mahale 2014-02-25 11:44:55 UTC
I have filed bug 725133 to add support for XRandR output border property and
mentioned use-cases there, this bug is to allow user to configure border.
Comment 1 Bastien Nocera 2014-02-26 15:34:06 UTC
Some documentation:
http://en.wikipedia.org/wiki/Overscan

What Apple does in this case:
http://support.apple.com/kb/HT5841

Having a way to setup the amount of overscan/underscan is clearly something we'd need to avoid clipped desktops when plugging into (digital or analogue) TVs.

Allan and Jakub will come up with some preliminary designs that we can iterate over.
Comment 3 Cosimo Cecchi 2015-06-30 21:57:00 UTC
Support for this in gnome-desktop and mutter has landed in master; I will be attaching the control-center patch we use in Endless.
It's not as fancy and configurable as in the mockup linked by Matthias above, but it's simple and very useful when connecting your laptop to a TV.
Comment 4 Cosimo Cecchi 2015-06-30 22:03:08 UTC
Created attachment 306444 [details] [review]
display: Add option to enable and disable overscan compensation
Comment 5 Cosimo Cecchi 2015-06-30 22:53:08 UTC
This also needs a mechanism to detect whether the driver supports underscanning at all. We are planning with Jasper to implement it in Mutter and add a gnome-desktop API similar to the rotation one.
Comment 6 Bastien Nocera 2015-07-01 09:01:53 UTC
Review of attachment 306444 [details] [review]:

Can you please post a current screenshot?

There should be one with the rotation buttons, and one without.

::: panels/display/cc-display-panel.c
@@ +1978,3 @@
+  gboolean value;
+
+  value = gtk_toggle_button_get_active (GTK_TOGGLE_BUTTON (check_button));

Why a check button rather than a switch?

@@ +2233,3 @@
+  if (!gnome_rr_output_is_builtin_display (output))
+    {
+      priv->scaling_check = gtk_check_button_new_with_label (_("Adjust screen for TV"));

Will need designer input for that option.
Comment 7 Cosimo Cecchi 2015-07-02 01:17:07 UTC
Mutter patches: https://git.gnome.org/browse/mutter/log/?h=wip/underscan (pending review from Jasper)
gnome-desktop dependency issue: https://bugzilla.gnome.org/show_bug.cgi?id=751814
Comment 8 Cosimo Cecchi 2015-07-02 01:17:40 UTC
Created attachment 306572 [details] [review]
display: Add option to enable and disable overscan compensation

--

New version that depends on the new gnome-desktop API
Comment 9 Cosimo Cecchi 2015-07-02 01:19:44 UTC
Created attachment 306573 [details]
screenshot

How it looks
Comment 10 Bastien Nocera 2015-07-02 09:50:21 UTC
(In reply to Cosimo Cecchi from comment #9)
> Created attachment 306573 [details]
> screenshot
> 
> How it looks

I'm guessing you hacked it so that the tick box would show, because I can't imagine why you'd want the internal display to show up that config option :)
Comment 11 Bastien Nocera 2015-07-02 09:54:00 UTC
Review of attachment 306572 [details] [review]:

I'll let Allan look at the rest.

::: panels/display/cc-display-panel.c
@@ +2232,3 @@
+  /* overscan */
+  if (!gnome_rr_output_is_builtin_display (output) &&
+      gnome_rr_output_supports_underscanning (output))

Could we, either here or in gnome-desktop (or maybe in mutter?) check whether the display is actually a TV, for example, does it have 1080p/1080i, is it 16/9? And similar checks for CRT screens possibly.
Comment 12 Bastien Nocera 2015-07-02 10:21:55 UTC
A couple of comments on the UI itself:
- I would prefer a switch, because the change has "physical" effects on the UI.
- "Scaling for TV" makes me think that other parts of the UI, like the shell chrome, or applications will be scaled to appear bigger on the TV screen

We need to convey that this is the switch will shrink the image on the TV to "uncrop" the default image, but without using negative connotations, because we don't want it to be seen as an "unbreak" my setup (because, we really should be default to unbroken, right).
Comment 13 Allan Day 2015-07-02 10:45:12 UTC
(In reply to Cosimo Cecchi from comment #9)
> Created attachment 306573 [details]
> screenshot
> 
> How it looks

The UI looks OK to me, although the checkbox isn't the neatest/clearest approach (you have two labels rather than one, for example). Also, as Bastien pointed out, the effect of this control is quite dramatic. A switch might be a better choice for that reason.

You could do something like:

Fit TV Display  [ On | Off ]

Or:

Adjust for TV   [ On | Off ]
Comment 14 Cosimo Cecchi 2016-04-03 18:13:09 UTC
Created attachment 325272 [details] [review]
display: add option to enable and disable overscan compensation

Adds a switch that allows to control overscan compensation, when the
driver supports it.

Based on a patch by Tomeu Vizoso <tomeu.vizoso@collabora.com>
Comment 15 Cosimo Cecchi 2016-04-03 18:14:24 UTC
Created attachment 325273 [details]
screenshot

How it looks v2
Comment 16 Cosimo Cecchi 2016-04-03 18:15:16 UTC
Thanks for the feedback - I updated the patch as for comments.
Comment 17 Bastien Nocera 2016-04-04 14:59:58 UTC
(In reply to Cosimo Cecchi from comment #16)
> Thanks for the feedback - I updated the patch as for comments.

That looks like an interdiff. Can you post a squashed patch?

Only change I would make would be to move the "adjust for TV" above "refresh rate", so the options are ordered in order of importance. Allan?
Comment 18 Cosimo Cecchi 2016-04-05 04:46:15 UTC
Created attachment 325401 [details] [review]
display: add option to enable and disable overscan compensation

--

Now with the full patch.
I think I prefer it this way because of the two comboboxes being near each other, and because resolution and refresh rate are similar things. But I can easily change it if others think otherwise.
Comment 19 Bastien Nocera 2016-04-05 08:20:50 UTC
Review of attachment 325401 [details] [review]:

Looks good, pending Allan's review on where the switch would go.
Comment 20 Allan Day 2016-04-05 11:41:19 UTC
(In reply to Bastien Nocera from comment #19)
> Review of attachment 325401 [details] [review] [review]:
> 
> Looks good, pending Allan's review on where the switch would go.

In my mind, the switch goes logically first - it's the "this is a TV" control, and "it's a TV" has consequences for refresh rate. Maybe that's just my naive way of looking at it though. :)
Comment 21 Cosimo Cecchi 2016-04-05 15:41:13 UTC
Created attachment 325442 [details] [review]
display: add option to enable and disable overscan compensation

--

Moved the switch above the refresh rate.
Comment 22 Bastien Nocera 2016-04-05 16:46:35 UTC
Review of attachment 325442 [details] [review]:

> Based on a patch by Tomeu Vizoso <tomeu.vizoso@collabora.com>

He's also marked as the author of the patch. So please either change this or don't forget --reset-author before committing :)

Please branch for gnome-3-20 before committing. Thanks for driving this through.
Comment 23 Cosimo Cecchi 2016-04-05 17:15:51 UTC
Fixed author and branched for gnome-3-20 before pushing.

Attachment 325442 [details] pushed as 47dcfee - display: add option to enable and disable overscan compensation