After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 724961 - Game not unpaused if using Reset Game when game is paused
Game not unpaused if using Reset Game when game is paused
Status: RESOLVED FIXED
Product: gnome-mahjongg
Classification: Applications
Component: general
3.10.x
Other Linux
: Normal minor
: ---
Assigned To: gnome-mahjongg-maint
gnome-mahjongg-maint
Depends on:
Blocks:
 
 
Reported: 2014-02-22 17:50 UTC by Michael Catanzaro
Modified: 2014-04-01 23:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Revert "Revert "Ensure game is unpaused after Restart Game"" (811 bytes, patch)
2014-03-23 00:53 UTC, Michael Catanzaro 		committed Details | Review

Description Michael Catanzaro 2014-02-22 17:50:26 UTC 
* Pause the game
* Click Reset game
* The game remains paused. It should be unpaused.

There's also a noticeable delay before the game is unpaused if using New Game instead of Reset Game.
Comment 1 Mario Wenzel 2014-02-23 09:36:31 UTC 
The noticeable delay should be the Puzzle generation. Not much we can do about that.
Comment 2 Michael Catanzaro 2014-03-13 02:09:47 UTC 
(In reply to comment #1)
> The noticeable delay should be the Puzzle generation. Not much we can do about
> that.

I guess that's fine. I probably should not have mentioned that here anyway, since it's unrelated to this bug.
Comment 3 Michael Catanzaro 2014-03-23 00:53:19 UTC 
Created attachment 272670 [details] [review]
Revert "Revert "Ensure game is unpaused after Restart Game""

This reverts commit e357d918c587e0856d30648b95a70f75e685085c.

I fixed this a while ago, but quickly reverted the change because I thought it was causing the clock to start immediately at the beginning of each game. But I can't reproduce that now, so I guess I was nuts and this is fine? Please double-check me on this....

For 3.12.1
Comment 4 Michael Catanzaro 2014-04-01 23:33:40 UTC 
Attachment 272670 [details] pushed as b7d2a69 - Revert "Revert "Ensure game is unpaused after Restart Game""