After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 724895 - Print dialog UI regressions
Print dialog UI regressions
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Printing
3.10.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2014-02-21 14:38 UTC by Marek Kašík
Modified: 2014-02-21 15:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix sensitivity of the Print button (1.30 KB, patch)
2014-02-21 14:42 UTC, Marek Kašík 		committed Details | Review
Fix visibility of tabs in print dialog (2.67 KB, patch)
2014-02-21 14:47 UTC, Marek Kašík 		committed Details | Review

Description Marek Kašík 2014-02-21 14:38:46 UTC 
There are two UI regressions in Gtk+ print dialog:

The first one is that there are shown tabs which shouldn't be when no printer is selected in 3.10.x. These are "Job", "Image Quality", "Color", "Finishing" and "Advanced".
This happened during the conversion of dialogs to UI files. These tabs should be set as hidden in the gtkprintunixdialog.ui because we didn't call gtk_widget_show() for their topmost widgets before.

The second one is sensitivity of "Print" button when no printer is selected. This is a regression in the latest development branch (3.11.x). This happened during conversion of some parts from the gtkprintunixdialog.ui back to gtkprintunixdialog.c.
Comment 1 Marek Kašík 2014-02-21 14:42:09 UTC 
Created attachment 269923 [details] [review]
Fix sensitivity of the Print button
Comment 2 Marek Kašík 2014-02-21 14:47:54 UTC 
Created attachment 269924 [details] [review]
Fix visibility of tabs in print dialog
Comment 3 Matthias Clasen 2014-02-21 14:57:44 UTC 
Review of attachment 269923 [details] [review]:

sure
Comment 4 Matthias Clasen 2014-02-21 14:58:32 UTC 
Review of attachment 269924 [details] [review]:

ok
Comment 5 Marek Kašík 2014-02-21 15:09:04 UTC 
Comment on attachment 269924 [details] [review]
Fix visibility of tabs in print dialog

Thank you for the reviews. I've committed both patches to master and the fix for visibility of tabs also to 3-10.

Marek