GNOME Bugzilla – Bug 724837
Handle --version command line option
Last modified: 2014-02-21 23:09:53 UTC
see patch
Created attachment 269843 [details] [review] patch
Review of attachment 269843 [details] [review]: ::: src/gl-application.c @@ +220,3 @@ +static const GOptionEntry options[] = +{ + { "version", 'v', 0, G_OPTION_ARG_NONE, NULL, N_("Print version information and exit"), NULL }, Is this more than 79 characters in length? Also, it's string change announcement period, so this will need an email to both gnome-i18n and gnome-doc-list. @@ +221,3 @@ +{ + { "version", 'v', 0, G_OPTION_ARG_NONE, NULL, N_("Print version information and exit"), NULL }, + { NULL} Missing a space after NULL. @@ +261,3 @@ priv->desktop = g_settings_new (DESKTOP_SCHEMA); + g_application_add_main_option_entries (G_APPLICATION (application), options); As this was added to GIO only recently, it needs a corresponding bump to the dependency in configure.ac.
Created attachment 269949 [details] [review] patch I can send the i18n mail when committing
Comment on attachment 269949 [details] [review] patch Looks great, please go ahead!
pushed and mail sent to i18n and docs