GNOME Bugzilla – Bug 724834
GTK Theme: tool/panel icons are a bit off
Last modified: 2018-05-24 14:18:59 UTC
Hello, I am running Ubuntu 12.04 and GIMP 2.8.10 I have been making a theme for GIMP that changes out all the icons. My theme can be downloaded here [1]. In my theme I have it set so that inactive tools are black/white and when you hover over them and select the tools they are GIMP orange. everything is fine here I got it all to work how I want. I wanted to have the panel tabs do the same, when inactive they are black/white and when you hover or select the tab they turn GIMP orange. The problem is when it comes to the Tools presets, and Gradient Editor. Ok so in my imagerc file for paintbrush I have these four lines which change out the icons. The "c" in front of 22 is my colored icon. As a tool box icon goes this works grate. The first line is the inactive button, second is active button, third is hover over button, and last is everything else. But as fare as the Tools Presets panel goes it all gets messed up. The first three lines do not seem to affect it and the fourth determins the icon. { "images/tools/stock-tool-paintbrush-22.svg", *, *, "gtk-button" }, { "images/tools/stock-tool-paintbrush-c22.svg", *, ACTIVE, "gtk-button" }, { "images/tools/stock-tool-paintbrush-c22.svg", *, PRELIGHT, "gtk-button" }, { "images/tools/stock-tool-paintbrush-22.svg", *, *, * } So I looked into "<size>" proporties and found "gtk-menu". at first I thought that this fixed the problem, but it turns out that the active state for the Tools Presets panel is what preset you have selected within the panel. { "images/tools/stock-tool-paintbrush-c22.svg", *, *, "gtk-menu" }, { "images/tools/stock-tool-paintbrush-c22.svg", *, ACTIVE, "gtk-menu" }, As far as I can tell There is no way to make Tools Presets icons change based upon whether the tab is active. Too make this look more consistent I believe that the icons should change based upon what tools preset is selected and the active state should use that tools active icon and be based upon whether the tab is active. For the Gradient Editor it seems as though it uses "gtk-button" as its <size>. The problem is that the first line is the Blend Tools inactive state and the Gradient Editors active state. and inverse is true that the second line is the blend tools active state and the Gradient Editors inactive state. I might have the size wrong but I tried all the default gtk+ <size> properties and it does not seem to change any. { "images/tools/stock-tool-blend-c22.svg", *, *, "gtk-button" }, { "images/tools/stock-tool-blend-22.svg", *, ACTIVE, "gtk-button" }, I really hope this makes since to you. [1] http://android272.deviantart.com/art/GIMP-Icon-Theme-Flat-375010811
Created attachment 270750 [details] icons that are a problem.
Created attachment 270751 [details] Problems with Navigation
That makes is very obvious, thanks. Will look into it.
I haven't looked into the matching logic that processes the *, ACTIVE etc. in: { "images/tools/stock-tool-paintbrush-22.svg", *, *, "gtk-button" }, { "images/tools/stock-tool-paintbrush-c22.svg", *, ACTIVE, "gtk-button" }, { "images/tools/stock-tool-paintbrush-c22.svg", *, PRELIGHT, "gtk-button" }, { "images/tools/stock-tool-paintbrush-22.svg", *, *, * } but it might be that the * overrides the other stuff, have you tried avoiding the * for the state field alltogether and write out all states explicitely? If that "fixes" it we'd at least know that the problem is in the matching logic and not in the drawing part. Please try that for some icons and report back. Thanks. The theme looks great btw, we should probably ship something like that with 2.10.
Well I thought about that before and double checked just now since I have added some lines to my code. But if you look at the code there is a c in between the - and the 22. In my theme this indicates that the icon is colored or orange. I only set active, prelight,and selected to colored. And then I set normal, * and "*,*,*" which is everything to noncolored icons. So all icons should be black or white until the user hovers over them, selects them or other wise is active then they turn orange.
Created attachment 270763 [details] New image: temples use different icons.
Created attachment 270997 [details] Every tab open aparently every panel is bad. The first tab is active and everything else is not. Panels: Layers, Layers, Channels, Paths, Colormap, Undo History, Color, Brushes, Brush Editor, Paint Dynamics, Paint Dynamics Editor, Patterns, Gradients, Gradients Editor, Palettes, Palettes Editor, Fonts, Tools Presets, Tool Presets Editor, Buffers, Images, Document History, Image Templates, Device Status, Error Console, Histogram, Navigation, Tools Options. The Error Console does not change at all.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gimp/issues/537.