After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 724705 - videomixer: Port to new collectpads API
videomixer: Port to new collectpads API
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal enhancement
: 1.3.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on: 726461
Blocks:
 
 
Reported: 2014-02-19 02:15 UTC by Mathieu Duponchelle
Modified: 2014-03-16 16:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
This patch ports videomixer to the new collectpads API (5.72 KB, patch)
2014-02-19 02:17 UTC, Mathieu Duponchelle 		committed Details | Review

Description Mathieu Duponchelle 2014-02-19 02:15:28 UTC 
The following commit removes flushing seeks related code from videomixer to let collectpads handle that logic itself.

It makes GES' test suites pass more reliably, but it depends on a change in collectpads that I'll describe in a different report, which I will link here.

Without that change, this patch should not be merged.
Comment 1 Mathieu Duponchelle 2014-02-19 02:17:06 UTC 
Created attachment 269651 [details] [review]
This patch ports videomixer to the new collectpads API
Comment 2 Sebastian Dröge (slomo) 2014-02-19 19:58:10 UTC 
This new API still needs some implementation changes, which I'm working on. Otherwise this makes a lot of sense :)
Comment 3 Mathieu Duponchelle 2014-03-16 16:35:08 UTC 
This bug depends on https://bugzilla.gnome.org/show_bug.cgi?id=726461
Comment 4 Sebastian Dröge (slomo) 2014-03-16 16:45:20 UTC 
commit 6cf0f19c14255ed2b3d6fa6451c393bac1d3c7a3
Author: Mathieu Duponchelle <mduponchelle1@gmail.com>
Date:   Wed Feb 19 03:04:03 2014 +0100

    videomixer: Port to new collectpads API
    
    See: https://bugzilla.gnome.org/show_bug.cgi?id=724705