After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 724690 - popupMenu: Make destroy() a bit more robust
popupMenu: Make destroy() a bit more robust
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2014-02-18 20:13 UTC by Florian Müllner
Modified: 2014-02-18 20:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
popupMenu: Make destroy() a bit more robust (1.29 KB, patch)
2014-02-18 20:13 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2014-02-18 20:13:05 UTC 
Noticed in relation to bug 724688, see patch.
Comment 1 Florian Müllner 2014-02-18 20:13:09 UTC 
Created attachment 269614 [details] [review]
popupMenu: Make destroy() a bit more robust

Currently destroying a menu's actor and calling its destroy() method
are subtly different - the latter will also result in the menu being
removed from the corresponding menu manager.
There is no good justification for that behavior, so make both actions
behave the same.
Comment 2 Jasper St. Pierre (not reading bugmail) 2014-02-18 20:21:54 UTC 
Review of attachment 269614 [details] [review]:

This makes sense.
Comment 3 Florian Müllner 2014-02-18 20:27:59 UTC 
Attachment 269614 [details] pushed as 3e7e88c - popupMenu: Make destroy() a bit more robust