GNOME Bugzilla – Bug 724686
Can't push windows beetween workspaces (create new workspace with window)
Last modified: 2014-02-23 08:59:08 UTC
I can't be more descriptive. I will attach screencast. gnome-shell-3.11.5-3.fc21.x86_64
Screencast: http://ignatenkobrain.fedorapeople.org/bgo724686.ogv
can reproduce on 3.9.90. I think that's blocker bug.
Created attachment 269880 [details] [review] workspaceThumbnails: Fix creating new workspace via DND Commit 61a58ff3c981d4 replaced the (removed in commit 254afc50223a7) MetaWindowActor.get_workspace() method by MetaWindow.get_workspace(), but did not take into account that the return values differ - the former returns the workspace index, the latter the workspace object.
Review of attachment 269880 [details] [review]: LG.
Attachment 269880 [details] pushed as 89a2dc7 - workspaceThumbnails: Fix creating new workspace via DND
colleagues, this patch improved new regression (thumbnails on other workspaces doesn't shows in some cases) and patch hasn't fixed main problem. after patch windows moving to existing workspace, but not create new workspace.
(In reply to comment #6) > colleagues, this patch improved new regression (thumbnails on other workspaces > doesn't shows in some cases) No. I've seen this problem occasionally before the patch was written - please file a separate bug for that. > and patch hasn't fixed main problem Whoops, the same problem fixed by the patch is present in more places. Patch coming.
Created attachment 270020 [details] [review] workspaceThumbnails: Really fix DND creating new workspaces The same problem spotted in commit 89a2dc71fc1ed is present in some more places, fix those as well.
Review of attachment 270020 [details] [review]: Yeah, I'm really sorry about this regression. It seems I wrote the patch before the API change to make meta_window_get_workspace() return MetaWorkspace* was made.
Attachment 270020 [details] pushed as f460762 - workspaceThumbnails: Really fix DND creating new workspaces
(In reply to comment #7) > (In reply to comment #6) > > colleagues, this patch improved new regression (thumbnails on other workspaces > > doesn't shows in some cases) > > No. I've seen this problem occasionally before the patch was written - please > file a separate bug for that. Ok. Thx. I'll do. > > > and patch hasn't fixed main problem > > Whoops, the same problem fixed by the patch is present in more places. Patch > coming. Heh, thank you for new patch. It works!