GNOME Bugzilla – Bug 724603
Automatically hide notes when a box is filled
Last modified: 2015-03-01 17:52:01 UTC
Created attachment 269494 [details] [review] Patch to hide notes when a number_box is filled When I play this game, I use the top notes to manually keep track of the available numbers. However, when I input a number in the square I don't need them any more, and I actually find them pretty distracting. I'd love it, then, if the notes would automatically hide when a square is filled. I'm attaching a patch that implements this. It's not a great patch because there should be an option to enable/disable this behaviour, you can still interact with the notes when they are hidden, and I'm not that familiar with the code to know if this is the best way to implement it. On the other side, I tested it and the content of the notes are preserved, and they are shown/hidden when a number is added/deleted manually, when you undo/redo or hide/show/delete a tracker. Any comments on how to improve the implementation are very welcome. Cheers, Arnoques
Review of attachment 269494 [details] [review]: Sorry this patch went unreviewed for so long. I agree that automatically clearing notes like this should be the default behavior, and I'm not sure that it should be configurable anyway. But at this point I'm only interested in patches for the vala-port branch, which will be merged into master probably within the next month or so.
I’ve seen a web implementation of a sudoku game that has an elegant solution: just let you input five numbers in the tile and have a lower font size when you have two or more. As notes are usually used to mark all-the-possible-numbers-of-this-tile, if you write only one, it’s that you think it’s the good number; if you enter more, it’s that you’re taking notes. Adapted to our game, it means only one popover by tile (I’ll talk about having only one popover elsewhere…), and when you check more than one togglebutton, use earmarks; else, use normal font size. And that would solve the touch problem[1]. [1] https://bugzilla.gnome.org/show_bug.cgi?id=733436
It would be nice to have only one popover, but the big disadvantage to that approach is that the normal case (no earmarks) becomes harder: the popover isn't immediately dismissed when selecting a number. So I hesitate to change that. The touch problem can be solved by using a long press to open the earmark popover.
(In reply to comment #3) > It would be nice to have only one popover, but the big disadvantage to that > approach is that the normal case (no earmarks) becomes harder: the popover > isn't immediately dismissed when selecting a number. So I hesitate to change > that. I think it’s a quite little thing regarding to the actual problems of the earmarks’ popovers, beginning by its discoverability. But, a solution for all could be to use a 3×3 “virtual keyboard” in the right column, instead of a popover; and that permits to always have a complete view of the grid. (The bigger problem is that I already have many plans for the right column. xD )
(In reply to comment #4) > I think it’s a quite little thing regarding to the actual problems of the > earmarks’ popovers, beginning by its discoverability. But, a solution for all > could be to use a 3×3 “virtual keyboard” in the right column, instead of a > popover; and that permits to always have a complete view of the grid. Yes, that would work. Allan requested that because he's no longer confident about the popover design. We actually had it recently, but got rid of it because it looked bad. > (The bigger problem is that I already have many plans for the right column. xD ) What?
Is this bug still valid?
Yes! We should automatically clear notes (now called "earmarks"). No need for a new preference, though: it should just happen always.
Created attachment 298205 [details] [review] Clear earmarks when a cell is filled
Looks good! Attachment 298205 [details] pushed as 35d3d50 - Clear earmarks when a cell is filled