GNOME Bugzilla – Bug 724471
Use header bar in the interactive dialog
Last modified: 2014-04-13 10:59:14 UTC
See the patch.
Created attachment 269289 [details] [review] screenshot: Use header bar in the interactive dialog
Attachment 269289 [details] pushed as a6d21b7 - screenshot: Use header bar in the interactive dialog Thanks, I pushed this one with a bunch of additional tweaks on top.
Please, revert this patch: https://git.gnome.org/browse/gnome-screenshot/commit/?id=fed91a9eac4a41e68f97338f99f4728b290c7ca5 I added this to be consistent with GTK+ dialogs, see this patch: https://git.gnome.org/browse/gtk+/commit/?id=e2a2d5012e7083bed1c15c4ddce5cff88d577e21 Also, I not sure this right: https://git.gnome.org/browse/gnome-screenshot/commit/?id=6c0b231ce5adda9304246636db7986dd8a861f2d
OK I fixed the size group part. The other commit is right - see https://git.gnome.org/browse/gtk+/tree/gtk/gtkbutton.c#n1278
In the save dialog, I think we wants to remove the Cancel button, and to add instead the X button, with the show-close-button property of GtkHeaderBar.
(In reply to comment #5) > In the save dialog, I think we wants to remove the Cancel button, > and to add instead the X button, with the show-close-button property > of GtkHeaderBar. Sounds good - want to make a patch? :-)
OK, one second.
Created attachment 269318 [details] [review] screenshot-dialog: Remove the cancel button and add X button instead
Review of attachment 269318 [details] [review]: Pushed as d8fcafe - screenshot-dialog: Remove the cancel button and add X button instead
*** Bug 711221 has been marked as a duplicate of this bug. ***