After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 724401 - gsubprocess: Mutex leak
gsubprocess: Mutex leak
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2014-02-15 07:26 UTC by Olivier Crête
Modified: 2014-02-17 01:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
subprocess: Clear the mutex on finalize (691 bytes, patch)
2014-02-15 07:26 UTC, Olivier Crête 		none Details | Review
subprocess: Init and clear the mutex (827 bytes, patch)
2014-02-15 07:31 UTC, Olivier Crête 		committed Details | Review

Description Olivier Crête 2014-02-15 07:26:43 UTC 
Created attachment 269175 [details] [review]
subprocess: Clear the mutex on finalize

Summary says it all
Comment 1 Olivier Crête 2014-02-15 07:31:27 UTC 
Created attachment 269182 [details] [review]
subprocess: Init and clear the mutex

Oops, just realized that g_mutex_clear() on a mutex that wasnt initialised was not safe.
Comment 2 Allison Karlitskaya (desrt) 2014-02-15 13:39:12 UTC 
Review of attachment 269182 [details] [review]:

Looks good -- thanks!
Comment 3 Olivier Crête 2014-02-17 01:03:59 UTC 
Comment on attachment 269182 [details] [review]
subprocess: Init and clear the mutex

Pushed as ed017994 - subprocess: Init and clear the mutex