After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 724385 - gtestutils: make the new assert messages more detailed
gtestutils: make the new assert messages more detailed
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2014-02-14 21:14 UTC by Dan Winship
Modified: 2014-02-17 16:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gtestutils: make the new assert messages more detailed (2.73 KB, patch)
2014-02-14 21:14 UTC, Dan Winship 		committed Details | Review

Description Dan Winship 2014-02-14 21:14:49 UTC 
g_assert_true(), g_assert_false(), g_assert_null(), and
g_assert_nonnull() simply printed out the expression they were
checking, without any further explanation of what went wrong. (In
particular, "g_assert_true(x)" and "g_assert_false(x)" would both
print the same thing on failure.) Add a little bit more context.
Comment 1 Dan Winship 2014-02-14 21:14:51 UTC 
Created attachment 269149 [details] [review]
gtestutils: make the new assert messages more detailed
Comment 2 Emmanuele Bassi (:ebassi) 2014-02-15 11:17:11 UTC 
Review of attachment 269149 [details] [review]:

looks good to me.
Comment 3 Dan Winship 2014-02-17 16:33:51 UTC 
Attachment 269149 [details] pushed as 5a44786 - gtestutils: make the new assert messages more detailed