After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 724364 - idle-monitor: avoid XSyncBadAlarm X error
idle-monitor: avoid XSyncBadAlarm X error
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2014-02-14 15:09 UTC by Allison Karlitskaya (desrt)
Modified: 2014-02-14 15:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
idle-monitor: avoid XSyncBadAlarm X error (1.03 KB, patch)
2014-02-14 15:09 UTC, Allison Karlitskaya (desrt)
committed Details | Review

Description Allison Karlitskaya (desrt) 2014-02-14 15:09:46 UTC
If we fail to find the IDLETIME counter, then the alarm variable will be
uninitialised.  Most code paths are careful to check this before
submitting XSync calls, but there is one check missing.
Comment 1 Allison Karlitskaya (desrt) 2014-02-14 15:09:52 UTC
Created attachment 269127 [details] [review]
idle-monitor: avoid XSyncBadAlarm X error
Comment 2 Jasper St. Pierre (not reading bugmail) 2014-02-14 15:22:33 UTC
Review of attachment 269127 [details] [review]:

OK.
Comment 3 Allison Karlitskaya (desrt) 2014-02-14 15:46:31 UTC
Attachment 269127 [details] pushed as ad1e23c - idle-monitor: avoid XSyncBadAlarm X error