After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 724258 - window: don't set _NET_WM_FULLSCREEN_MONITORS to bogus values
window: don't set _NET_WM_FULLSCREEN_MONITORS to bogus values
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2014-02-13 00:24 UTC by Giovanni Campagna
Modified: 2014-02-13 12:10 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
window: don't set _NET_WM_FULLSCREEN_MONITORS to bogus values (4.29 KB, patch)
2014-02-13 00:24 UTC, Giovanni Campagna
committed Details | Review

Description Giovanni Campagna 2014-02-13 00:24:49 UTC
Prior to the DisplayConfig merge, we would set _NET_WM_FULLSCREEN_MONITORS
to (unsigned)-1 when unset. After that, we would have invalid
reads inside meta_screen_monitor_index_to_xinerama_index() (called
with -1).
The way I read the specification, the proper way to indicate
that the window is back to fullscreen on all monitors is to
remove the property, so do that.

Also, add an assertion that meta_screne_monitor_index_to_xinerama_index()
is doing the right thing.
Comment 1 Giovanni Campagna 2014-02-13 00:24:51 UTC
Created attachment 268967 [details] [review]
window: don't set _NET_WM_FULLSCREEN_MONITORS to bogus values
Comment 2 Jasper St. Pierre (not reading bugmail) 2014-02-13 00:40:19 UTC
Review of attachment 268967 [details] [review]:

Looks OK.
Comment 3 Giovanni Campagna 2014-02-13 12:10:44 UTC
Attachment 268967 [details] pushed as 3aac2bf - window: don't set _NET_WM_FULLSCREEN_MONITORS to bogus values