GNOME Bugzilla – Bug 724037
Miscellaneous print fixes
Last modified: 2014-02-11 07:50:22 UTC
Two things: 1) We are not showing any indication of a document failing to print. 2) We are not exiting the selection mode immediately after the user action has completed. Instead we wait for the printing to actually finish. In some cases, a document might take a few seconds to print and we keep lingering in selection mode.
Created attachment 268680 [details] [review] documents: Miscellaneous printing fixes
Created attachment 268681 [details] [review] notifications: Remove unused code
(From a downstream bug report) Here is one way to trigger a printing error: - Select a PostScript (*.ps) file - Try to print to file and choose PDF as the output
Created attachment 268682 [details] Screenshot of error from evince
Created attachment 268683 [details] Screenshot of error from gnome-documents This is loosely based on the error dialog that is shown for sharing errors. Not sure if the message-type should be ERROR or WARNING, or if the button should be OK or CLOSE.
Bug 724044 is about avoiding the PostScript / PDF situation all together. However, I don't think we can predict and avoid all possible eventualities that might cause the print to fail.
Review of attachment 268680 [details] [review]: Thanks - looks good to me. We can follow-up with tweaks to the error dialog if needed.
Review of attachment 268681 [details] [review]: Sure
Thanks for the review.