GNOME Bugzilla – Bug 723919
Patch for Totem --as-needed build error
Last modified: 2014-02-08 23:56:41 UTC
Created attachment 268520 [details] [review] patch from Mageia make[4]: Entering directory '/home/iurt/rpmbuild/BUILD/totem-3.11.5/src' CCLD libtotem.la .libs/libtotem_la-totem-grilo.o: In function `update_search_thumbnails_idle': /home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:351: undefined reference to `gd_main_view_get_type' /home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:351: undefined reference to `gd_main_view_get_generic_view' .libs/libtotem_la-totem-grilo.o: In function `get_thumbnail_cb': /home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:274: undefined reference to `gd_main_view_get_type' /home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:274: undefined reference to `gd_main_view_get_model' .libs/libtotem_la-totem-grilo.o: In function `delete_cb': /home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:1913: undefined reference to `gd_main_view_get_type' /home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:1913: undefined reference to `gd_main_view_get_model' /home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:1914: undefined reference to `gd_main_view_get_selection' .libs/libtotem_la-totem-grilo.o: In function `play_selection': /home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:1781: undefined reference to `gd_main_view_get_type' /home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:1781: undefined reference to `gd_main_view_get_selection' /home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:1782: undefined reference to `gd_main_view_get_model' .libs/libtotem_la-totem-grilo.o: In function `selection_mode_requested': /home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:1545: undefined reference to `gd_main_view_get_type' /home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:1545: undefined reference to `gd_main_view_set_selection_mode' .libs/libtotem_la-totem-grilo.o: In function `set_browser_filter_model_for_path': /home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:817: undefined reference to `gd_main_view_get_type' /home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:817: undefined reference to `gd_main_view_set_model' .libs/libtotem_la-totem-grilo.o: In function `view_selection_changed_cb': /home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:1576: undefined reference to `gd_main_view_get_selection' /home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:1577: undefined reference to `gd_main_view_get_model' .libs/libtotem_la-totem-grilo.o: In function `select_none_action_cb': /home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:1607: undefined reference to `gd_main_view_get_type' .libs/libtotem_la-totem-grilo.o: In function `select_all_action_cb': /home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:1599: undefined reference to `gd_main_view_get_type' .libs/libtotem_la-totem-grilo.o: In function `source_switched': /home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:1625: undefined reference to `gd_main_view_get_type' /home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:1621: undefined reference to `gd_main_view_get_type' .libs/libtotem_la-totem-grilo.o: In function `search_mode_changed': /home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:1695: undefined reference to `gd_main_view_get_type' /home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:1695: undefined reference to `gd_main_view_get_model' .libs/libtotem_la-totem-grilo.o: In function `setup_browse': /home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:2012: undefined reference to `gd_main_view_get_type' /home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:2012: undefined reference to `gd_main_view_set_model' .libs/libtotem_la-totem-grilo.o: In function `get_more_browse_results_cb': /home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:1380: undefined reference to `gd_main_view_get_type' /home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:1380: undefined reference to `gd_main_view_get_generic_view' /home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:1385: undefined reference to `gd_main_view_get_model' .libs/libtotem_la-totem-grilo.o: In function `search': /home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:775: undefined reference to `gd_main_view_get_type' /home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:775: undefined reference to `gd_main_view_set_model' .libs/libtotem_la-totem-grilo.o: In function `item_activated_cb': /home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:937: undefined reference to `gd_main_view_get_model' .libs/libtotem_la-totem-grilo.o: In function `browser_activated_cb': /home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:855: undefined reference to `gd_main_view_get_type' /home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:855: undefined reference to `gd_main_view_get_model' .libs/libtotem_la-totem-grilo.o: In function `search_activated_cb': /home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:915: undefined reference to `gd_main_view_get_model' .libs/libtotem_la-totem-grilo.o: In function `totem_grilo_back_button_clicked': /home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:1489: undefined reference to `gd_main_view_get_type' /home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:1489: undefined reference to `gd_main_view_set_model' /home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:1492: undefined reference to `gd_main_view_set_selection_mode' .libs/libtotem_la-totem-grilo.o: In function `select_none_action_cb': /home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:1607: undefined reference to `gd_main_view_unselect_all' .libs/libtotem_la-totem-grilo.o: In function `select_all_action_cb': /home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:1599: undefined reference to `gd_main_view_select_all' .libs/libtotem_la-totem-grilo.o: In function `source_switched': /home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:1625: undefined reference to `gd_main_view_set_model' /home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:1625: undefined reference to `gd_main_view_set_model' .libs/libtotem_la-totem-search-entry.o: In function `tag_clicked_cb': /home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-search-entry.c:76: undefined reference to `gd_tagged_entry_tag_get_area' .libs/libtotem_la-totem-search-entry.o: In function `listbox_row_activated': /home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-search-entry.c:100: undefined reference to `gd_tagged_entry_tag_set_label' .libs/libtotem_la-totem-search-entry.o: In function `totem_search_entry_init': /home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-search-entry.c:141: undefined reference to `gd_tagged_entry_new' /home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-search-entry.c:142: undefined reference to `gd_tagged_entry_get_type' /home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-search-entry.c:142: undefined reference to `gd_tagged_entry_set_tag_button_visible' .libs/libtotem_la-totem-search-entry.o: In function `totem_search_entry_add_source': /home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-search-entry.c:263: undefined reference to `gd_tagged_entry_tag_new' /home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-search-entry.c:264: undefined reference to `gd_tagged_entry_tag_set_has_close_button' /home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-search-entry.c:265: undefined reference to `gd_tagged_entry_get_type' /home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-search-entry.c:265: undefined reference to `gd_tagged_entry_insert_tag' .libs/libtotem_la-totem-search-entry.o: In function `totem_search_entry_remove_source': /home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-search-entry.c:330: undefined reference to `gd_tagged_entry_get_type' /home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-search-entry.c:330: undefined reference to `gd_tagged_entry_remove_tag' collect2: error: ld returned 1 exit status Makefile:956: recipe for target 'libtotem.la' failed make[4]: *** [libtotem.la] Error 1
For build output at http://pkgsubmit.mageia.org/uploads/failure/cauldron/core/release/20140208172226.tv.valstar.20305/log/totem-3.11.5-1.mga5/build.0.20140208172305.log Patch created by Jani Välimaa aka wally.
Review of attachment 268520 [details] [review]: Looks fine, but the patch needs to be git-formatted.
Created attachment 268526 [details] [review] git-formatted patch Here's the patch in git format.