After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 723919 - Patch for Totem --as-needed build error
Patch for Totem --as-needed build error
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: general
3.11.x
Other Linux
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-02-08 19:32 UTC by Olav Vitters
Modified: 2014-02-08 23:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch from Mageia (572 bytes, patch)
2014-02-08 19:32 UTC, Olav Vitters
needs-work Details | Review
git-formatted patch (776 bytes, patch)
2014-02-08 21:07 UTC, wally
committed Details | Review

Description Olav Vitters 2014-02-08 19:32:50 UTC
Created attachment 268520 [details] [review]
patch from Mageia

make[4]: Entering directory '/home/iurt/rpmbuild/BUILD/totem-3.11.5/src'
  CCLD     libtotem.la
.libs/libtotem_la-totem-grilo.o: In function `update_search_thumbnails_idle':
/home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:351: undefined reference to `gd_main_view_get_type'
/home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:351: undefined reference to `gd_main_view_get_generic_view'
.libs/libtotem_la-totem-grilo.o: In function `get_thumbnail_cb':
/home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:274: undefined reference to `gd_main_view_get_type'
/home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:274: undefined reference to `gd_main_view_get_model'
.libs/libtotem_la-totem-grilo.o: In function `delete_cb':
/home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:1913: undefined reference to `gd_main_view_get_type'
/home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:1913: undefined reference to `gd_main_view_get_model'
/home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:1914: undefined reference to `gd_main_view_get_selection'
.libs/libtotem_la-totem-grilo.o: In function `play_selection':
/home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:1781: undefined reference to `gd_main_view_get_type'
/home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:1781: undefined reference to `gd_main_view_get_selection'
/home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:1782: undefined reference to `gd_main_view_get_model'
.libs/libtotem_la-totem-grilo.o: In function `selection_mode_requested':
/home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:1545: undefined reference to `gd_main_view_get_type'
/home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:1545: undefined reference to `gd_main_view_set_selection_mode'
.libs/libtotem_la-totem-grilo.o: In function `set_browser_filter_model_for_path':
/home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:817: undefined reference to `gd_main_view_get_type'
/home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:817: undefined reference to `gd_main_view_set_model'
.libs/libtotem_la-totem-grilo.o: In function `view_selection_changed_cb':
/home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:1576: undefined reference to `gd_main_view_get_selection'
/home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:1577: undefined reference to `gd_main_view_get_model'
.libs/libtotem_la-totem-grilo.o: In function `select_none_action_cb':
/home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:1607: undefined reference to `gd_main_view_get_type'
.libs/libtotem_la-totem-grilo.o: In function `select_all_action_cb':
/home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:1599: undefined reference to `gd_main_view_get_type'
.libs/libtotem_la-totem-grilo.o: In function `source_switched':
/home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:1625: undefined reference to `gd_main_view_get_type'
/home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:1621: undefined reference to `gd_main_view_get_type'
.libs/libtotem_la-totem-grilo.o: In function `search_mode_changed':
/home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:1695: undefined reference to `gd_main_view_get_type'
/home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:1695: undefined reference to `gd_main_view_get_model'
.libs/libtotem_la-totem-grilo.o: In function `setup_browse':
/home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:2012: undefined reference to `gd_main_view_get_type'
/home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:2012: undefined reference to `gd_main_view_set_model'
.libs/libtotem_la-totem-grilo.o: In function `get_more_browse_results_cb':
/home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:1380: undefined reference to `gd_main_view_get_type'
/home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:1380: undefined reference to `gd_main_view_get_generic_view'
/home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:1385: undefined reference to `gd_main_view_get_model'
.libs/libtotem_la-totem-grilo.o: In function `search':
/home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:775: undefined reference to `gd_main_view_get_type'
/home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:775: undefined reference to `gd_main_view_set_model'
.libs/libtotem_la-totem-grilo.o: In function `item_activated_cb':
/home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:937: undefined reference to `gd_main_view_get_model'
.libs/libtotem_la-totem-grilo.o: In function `browser_activated_cb':
/home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:855: undefined reference to `gd_main_view_get_type'
/home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:855: undefined reference to `gd_main_view_get_model'
.libs/libtotem_la-totem-grilo.o: In function `search_activated_cb':
/home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:915: undefined reference to `gd_main_view_get_model'
.libs/libtotem_la-totem-grilo.o: In function `totem_grilo_back_button_clicked':
/home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:1489: undefined reference to `gd_main_view_get_type'
/home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:1489: undefined reference to `gd_main_view_set_model'
/home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:1492: undefined reference to `gd_main_view_set_selection_mode'
.libs/libtotem_la-totem-grilo.o: In function `select_none_action_cb':
/home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:1607: undefined reference to `gd_main_view_unselect_all'
.libs/libtotem_la-totem-grilo.o: In function `select_all_action_cb':
/home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:1599: undefined reference to `gd_main_view_select_all'
.libs/libtotem_la-totem-grilo.o: In function `source_switched':
/home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:1625: undefined reference to `gd_main_view_set_model'
/home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-grilo.c:1625: undefined reference to `gd_main_view_set_model'
.libs/libtotem_la-totem-search-entry.o: In function `tag_clicked_cb':
/home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-search-entry.c:76: undefined reference to `gd_tagged_entry_tag_get_area'
.libs/libtotem_la-totem-search-entry.o: In function `listbox_row_activated':
/home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-search-entry.c:100: undefined reference to `gd_tagged_entry_tag_set_label'
.libs/libtotem_la-totem-search-entry.o: In function `totem_search_entry_init':
/home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-search-entry.c:141: undefined reference to `gd_tagged_entry_new'
/home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-search-entry.c:142: undefined reference to `gd_tagged_entry_get_type'
/home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-search-entry.c:142: undefined reference to `gd_tagged_entry_set_tag_button_visible'
.libs/libtotem_la-totem-search-entry.o: In function `totem_search_entry_add_source':
/home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-search-entry.c:263: undefined reference to `gd_tagged_entry_tag_new'
/home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-search-entry.c:264: undefined reference to `gd_tagged_entry_tag_set_has_close_button'
/home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-search-entry.c:265: undefined reference to `gd_tagged_entry_get_type'
/home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-search-entry.c:265: undefined reference to `gd_tagged_entry_insert_tag'
.libs/libtotem_la-totem-search-entry.o: In function `totem_search_entry_remove_source':
/home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-search-entry.c:330: undefined reference to `gd_tagged_entry_get_type'
/home/iurt/rpmbuild/BUILD/totem-3.11.5/src/totem-search-entry.c:330: undefined reference to `gd_tagged_entry_remove_tag'
collect2: error: ld returned 1 exit status
Makefile:956: recipe for target 'libtotem.la' failed
make[4]: *** [libtotem.la] Error 1
Comment 2 Bastien Nocera 2014-02-08 19:47:05 UTC
Review of attachment 268520 [details] [review]:

Looks fine, but the patch needs to be git-formatted.
Comment 3 wally 2014-02-08 21:07:12 UTC
Created attachment 268526 [details] [review]
git-formatted patch

Here's the patch in git format.