GNOME Bugzilla – Bug 723892
mpegts: Some bugfixes regarding packetizing
Last modified: 2014-02-08 17:40:50 UTC
Created attachment 268483 [details] [review] mpegts: Fix some packetizing bugs Fixes for some bugs that found their way into the newly merged mpegts section patches.
commit 972f7ea71f078648b0a895d07a1d1f16490eb3fa Author: Jesper Larsen <knorr.jesper@gmail.com> Date: Sat Feb 8 13:08:02 2014 +0100 mpegts: Fix some packetizing bugs - Length of NIT stream descriptors was not detected correct - Reserved bits was not set according to EN 300 468, ISO/IEC 13818-1 - Also set output data size if the section was previously packetized https://bugzilla.gnome.org/show_bug.cgi?id=723892
Created attachment 268508 [details] [review] [V2] mpegts: Fix some packetizing bugs A more clean implementation
Comment on attachment 268508 [details] [review] [V2] mpegts: Fix some packetizing bugs Can you provide this patch against latest git master? It does not apply anymore because of your previous patch :)
Created attachment 268509 [details] [review] mpegts: Correctly check for PAT,PMT,CAT,TSDT I had not seen that you had merged the patch. This patch is not just for beauty, as it doesn't take a genius to spot that the if statement in the first patch is bogus. ;) By some magic chance it did work on the first test case I used. Anyway, this patch is a fix to the fix. I'll step away from the git now and return when my heads i functional agian. ;) Sorry for the noise in the history.
Created attachment 268513 [details] [review] mpegts: pmt: Detect descriptor length correct Found another small bug
Comment on attachment 268509 [details] [review] mpegts: Correctly check for PAT,PMT,CAT,TSDT Oops :) Well, with your broken patch it would almost always go into the 0x7000 case... so work as good as the previous code ;) commit f1c8de4bc28eb28ea74c88c24fe8dddf047dc16a Author: Jesper Larsen <knorr.jesper@gmail.com> Date: Sat Feb 8 17:43:03 2014 +0100 mpegts: Correctly check for PAT,PMT,CAT,TSDT