After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 723828 - Preferences window UI issues
Preferences window UI issues
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Movie player
3.11.x
Other Linux
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
3.12
Depends on:
Blocks:
 
 
Reported: 2014-02-07 10:24 UTC by Allan Day
Modified: 2014-02-10 11:04 UTC
See Also:
GNOME target: ---
GNOME version: 3.11/3.12

Attachments
Correct spacing and title of preference window (1.19 KB, patch)
2014-02-08 15:28 UTC, Baptiste Mille-Mathias 		committed Details | Review
screenshot (before/after) (23.63 KB, image/png)
2014-02-08 15:50 UTC, Baptiste Mille-Mathias 		  Details
Set preferences window modal and transient to main window. (1.66 KB, patch)
2014-02-08 16:31 UTC, Baptiste Mille-Mathias 		committed Details | Review
totem preferences window w/o headerbar (18.80 KB, image/png)
2014-02-08 16:35 UTC, Baptiste Mille-Mathias 		  Details

Description Allan Day 2014-02-07 10:24:26 UTC 
* Dialog should be modal
 * Title should be "Preferences", not "Totem Preferences".
 * The notebook is missing any padding around it, and looks a bit odd (padding should probably be the usual 12px).
Comment 1 Baptiste Mille-Mathias 2014-02-08 15:28:48 UTC 
Created attachment 268500 [details] [review]
Correct spacing and title of preference window
Comment 2 Baptiste Mille-Mathias 2014-02-08 15:50:07 UTC 
Created attachment 268503 [details]
screenshot (before/after)
Comment 3 Baptiste Mille-Mathias 2014-02-08 16:31:17 UTC 
Created attachment 268505 [details] [review]
Set preferences window modal and transient to main window.

Changed also the hint of the preference window to dialog else modal/transient
properties don't work.
Comment 4 Baptiste Mille-Mathias 2014-02-08 16:35:46 UTC 
Created attachment 268506 [details]
totem preferences window w/o headerbar
Comment 5 Bastien Nocera 2014-02-08 17:40:43 UTC 
Review of attachment 268500 [details] [review]:

Looks good, pending ui review.
Comment 6 Bastien Nocera 2014-02-08 17:41:40 UTC 
Review of attachment 268505 [details] [review]:

Looks good.
Comment 7 Baptiste Mille-Mathias 2014-02-08 17:45:04 UTC 
Attachment 268500 [details] pushed as 90f9def - Correct spacing and title of preference window
Attachment 268505 [details] pushed as 6188498 - Set preferences window modal and transient to main window.
Comment 8 Allan Day 2014-02-10 11:04:37 UTC 
(In reply to comment #2)
> Created an attachment (id=268503) [details]
> screenshot (before/after)

Looks great!