GNOME Bugzilla – Bug 723811
Smart Playlist Editor has greater width than screen
Last modified: 2014-03-29 15:21:52 UTC
Created attachment 268369 [details] [review] Swaps Double.MaxValue for int.MaxValue on a Spinner Control While using Gnome 3, I've noticed that opening the smart playlist editor results in a dialog that is complete and normal height, but is perhaps three times the screen width. Obviously this makes it very difficult to use. I've attached a patch which corrects the problem on my system, turned out the problem was in Hyena, is this still the correct place to file? Thanks.
Hey Nicholas, can you post screenshots for the before and after? Sorry it took so long to reply to this...
Created attachment 269647 [details] Before
Created attachment 269648 [details] After nicholas@shambles ~/Pictures $ file *.png Screenshot from 2014-02-19 01:18:10.png: PNG image data, 3321 x 304, 8-bit/color RGBA, non-interlaced Screenshot from 2014-02-19 01:23:27.png: PNG image data, 630 x 304, 8-bit/color RGBA, non-interlaced Here you go :)
Thanks for the screenshots, Nicholas. Can you attach fullscreen shots instead? I think the issue would be clearer with them. Sorry that I haven't replied earlier!
Unfortunately not at the minute! I'm unable to successfully compile banshee's GIO module :( I'll make the necessary screen shots when I get round to sorting it. Is the image size not representative enough? Width of 3321 vs 630 :)
(In reply to comment #5) > Is the image size not representative enough? Width of 3321 vs 630 :) Well, that's the thing, I bet that you didn't actually see that image, you just were able to capture it via ALT+PrntScreen, right? Best way would be to see the image going outside the boundaries of the screen.
Created attachment 273229 [details] Before Screen An updated before screenshot
Ok! BTW I have to apologize for asking the last screenshots, because I can actually reproduce the bug! The thing is, this bug seems to be a gtk3 regression (because I can't reproduce it in the stable branch), therefore it's not really a hyena bug. So, can you please open a new bug report about https://developer.gnome.org/gtk3/stable/GtkSpinButton.html#gtk-spin-button-new-with-range? Ideally it would include a very simple testcase (i.e.: a single-file python app) that reproduces the problem. After you have reported it, I will commit your patch to hyena (but adding a comment that explicitly says that the usage of int.MaxValue instead of Double.MaxValue is actually a workaround, and referencing the URL of the new bug report against gtk+). Thanks!
Sounds Good :) Don't worry about it, my gtk-sharp build was broken so gudev-sharp was building essentially a blank dll. Ack, back to the cairo memory leak warnings for me! After committing the workaround perhaps we should keep this one open and link it to 727294? So when the regression is remedied and we get notification, we can revert the workaround?
Comment on attachment 268369 [details] [review] Swaps Double.MaxValue for int.MaxValue on a Spinner Control (In reply to bug 727294 comment #2) > What's a double in python? No idea, but FYI int.MaxValue in C# is 2147483647, and Double.MaxValue is 1.79769313486232E+308 , so you could modify your testcase there to include the latter (or doing a binary search, the lowest gdouble that starts showing the bug). (In reply to comment #9) > Sounds Good :) Don't worry about it, my gtk-sharp build was broken so > gudev-sharp was building essentially a blank dll. Ack, back to the cairo memory > leak warnings for me! > > After committing the workaround perhaps we should keep this one open and link > it to 727294? > > So when the regression is remedied and we get notification, we can revert the > workaround? No need, as we're already both subscribed to the gtk+ bug. And in theory by adding the workaround, the banshee bug is really fixed (because lowering the max to 2147483647 is honestly not a big deal). I've committed your patch now, with a bigger commit msg.
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report, and patch!