After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 723804 - nm-vpnc-service: Fix argv passed to vpnc
nm-vpnc-service: Fix argv passed to vpnc
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: VPN: vpnc
unspecified
Other All
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-02-06 22:51 UTC by Florian Müllner
Modified: 2014-02-07 00:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
nm-vpnc-service: Fix argv passed to vpnc (1.27 KB, patch)
2014-02-06 22:51 UTC, Florian Müllner 		none Details | Review
nm-vpnc-service: Fix argv passed to vpnc (1.93 KB, patch)
2014-02-06 23:14 UTC, Florian Müllner 		none Details | Review

Description Florian Müllner 2014-02-06 22:51:02 UTC 
VPN on rawhide is broken which is bad for work - see patch :-)
Comment 1 Florian Müllner 2014-02-06 22:51:04 UTC 
Created attachment 268360 [details] [review]
nm-vpnc-service: Fix argv passed to vpnc

Passing --pid-file option and its argument in a single string isn't
understood by vpnc's option parser - both have to be passed as separate
argv members.
Comment 2 Thomas Haller 2014-02-06 23:10:11 UTC 
Hi,

this looks correct to me. But could you please get rid of the pid_arg variable entirely and pass priv->pid_file to  g_ptr_array_add directly?
Comment 3 Florian Müllner 2014-02-06 23:14:25 UTC 
Created attachment 268363 [details] [review]
nm-vpnc-service: Fix argv passed to vpnc

Sure!
Comment 4 Thomas Haller 2014-02-07 00:00:25 UTC 
Hi Florian,

commited as https://git.gnome.org/browse/network-manager-vpnc/commit/?id=6a38ce67e68900b6f17832541806611c40023877

Bugfix release for rawhide follows tomorrow.

Thank you
Thomas