After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 723769 - gnome-control-center-3.11.5 fails to build: 'nm_setting_team_get_type' undeclared
gnome-control-center-3.11.5 fails to build: 'nm_setting_team_get_type' undecl...
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Network
3.11.x
Other Linux
: Normal critical
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
: 723799 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2014-02-06 15:00 UTC by Baste
Modified: 2014-02-18 15:54 UTC
See Also:
GNOME target: 3.12
GNOME version: ---

Attachments
network: Fix build with NM 0.9.8.x (1.87 KB, patch)
2014-02-12 12:38 UTC, Bastien Nocera 		none Details | Review
network: Fix build with NM 0.9.8.x (2.93 KB, patch)
2014-02-12 12:43 UTC, Bastien Nocera 		reviewed Details | Review
network: Fix build with NM 0.9.8.x (3.18 KB, patch)
2014-02-12 12:56 UTC, Bastien Nocera 		committed Details | Review

Description Baste 2014-02-06 15:00:57 UTC 
Hi,

i'm try to build g-c-c 3.11.5 but have error.

Networkmanager version: 0.9.8.8
nm-applet version: 0.9.8.8

Log :
...
make  all-am
make[6]: Entering directory `/var/tmp/fst/src/gnome-control-center-3.11.5/panels/network/connection-editor'
/bin/sh ../../../libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I../../..  -I../../../ -DG_LOG_DOMAIN="\"-cc-panel\"" -DPANEL_ID="\"\"" -I./../wireless-security -pthread -I/usr/include/gtk-3.0 -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/pixman-1 -I/usr/include/libpng14 -I/usr/include/libdrm -I/usr/include/gsettings-desktop-schemas   -pthread -I/usr/include/NetworkManager -I/usr/include/libnm-glib -I/usr/include/dbus-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/lib/dbus-1.0/include -I/usr/include/libnm-gtk -I/usr/include/gtk-3.0 -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/pixman-1 -I/usr/include/libpng14 -I/usr/include/libdrm -I/usr/include/libmm-glib -I/usr/include/ModemManager   -DNM_VPN_CONFIG_DIR=\""/etc/NetworkManager/VPN"\" -DNM_VPN_MODULE_DIR=\""/usr/lib/NetworkManager"\"   -march=x86-64 -mtune=generic -O2 -pipe -I/usr/include/cheese -I/usr/include/gstreamer-1.0 -I/usr/include/libxml2 -MT libconnection_editor_la-net-connection-editor.lo -MD -MP -MF .deps/libconnection_editor_la-net-connection-editor.Tpo -c -o libconnection_editor_la-net-connection-editor.lo `test -f 'net-connection-editor.c' || echo './'`net-connection-editor.c
/bin/sh ../../../libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I../../..  -I../../../ -DG_LOG_DOMAIN="\"-cc-panel\"" -DPANEL_ID="\"\"" -I./../wireless-security -pthread -I/usr/include/gtk-3.0 -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/pixman-1 -I/usr/include/libpng14 -I/usr/include/libdrm -I/usr/include/gsettings-desktop-schemas   -pthread -I/usr/include/NetworkManager -I/usr/include/libnm-glib -I/usr/include/dbus-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/lib/dbus-1.0/include -I/usr/include/libnm-gtk -I/usr/include/gtk-3.0 -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/pixman-1 -I/usr/include/libpng14 -I/usr/include/libdrm -I/usr/include/libmm-glib -I/usr/include/ModemManager   -DNM_VPN_CONFIG_DIR=\""/etc/NetworkManager/VPN"\" -DNM_VPN_MODULE_DIR=\""/usr/lib/NetworkManager"\"   -march=x86-64 -mtune=generic -O2 -pipe -I/usr/include/cheese -I/usr/include/gstreamer-1.0 -I/usr/include/libxml2 -MT libconnection_editor_la-ce-page-security.lo -MD -MP -MF .deps/libconnection_editor_la-ce-page-security.Tpo -c -o libconnection_editor_la-ce-page-security.lo `test -f 'ce-page-security.c' || echo './'`ce-page-security.c
/bin/sh ../../../libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I../../..  -I../../../ -DG_LOG_DOMAIN="\"-cc-panel\"" -DPANEL_ID="\"\"" -I./../wireless-security -pthread -I/usr/include/gtk-3.0 -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/pixman-1 -I/usr/include/libpng14 -I/usr/include/libdrm -I/usr/include/gsettings-desktop-schemas   -pthread -I/usr/include/NetworkManager -I/usr/include/libnm-glib -I/usr/include/dbus-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/lib/dbus-1.0/include -I/usr/include/libnm-gtk -I/usr/include/gtk-3.0 -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/pixman-1 -I/usr/include/libpng14 -I/usr/include/libdrm -I/usr/include/libmm-glib -I/usr/include/ModemManager   -DNM_VPN_CONFIG_DIR=\""/etc/NetworkManager/VPN"\" -DNM_VPN_MODULE_DIR=\""/usr/lib/NetworkManager"\"   -march=x86-64 -mtune=generic -O2 -pipe -I/usr/include/cheese -I/usr/include/gstreamer-1.0 -I/usr/include/libxml2 -MT libconnection_editor_la-ce-page-reset.lo -MD -MP -MF .deps/libconnection_editor_la-ce-page-reset.Tpo -c -o libconnection_editor_la-ce-page-reset.lo `test -f 'ce-page-reset.c' || echo './'`ce-page-reset.c
/bin/sh ../../../libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I../../..  -I../../../ -DG_LOG_DOMAIN="\"-cc-panel\"" -DPANEL_ID="\"\"" -I./../wireless-security -pthread -I/usr/include/gtk-3.0 -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/pixman-1 -I/usr/include/libpng14 -I/usr/include/libdrm -I/usr/include/gsettings-desktop-schemas   -pthread -I/usr/include/NetworkManager -I/usr/include/libnm-glib -I/usr/include/dbus-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/lib/dbus-1.0/include -I/usr/include/libnm-gtk -I/usr/include/gtk-3.0 -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/pixman-1 -I/usr/include/libpng14 -I/usr/include/libdrm -I/usr/include/libmm-glib -I/usr/include/ModemManager   -DNM_VPN_CONFIG_DIR=\""/etc/NetworkManager/VPN"\" -DNM_VPN_MODULE_DIR=\""/usr/lib/NetworkManager"\"   -march=x86-64 -mtune=generic -O2 -pipe -I/usr/include/cheese -I/usr/include/gstreamer-1.0 -I/usr/include/libxml2 -MT libconnection_editor_la-ce-page-ethernet.lo -MD -MP -MF .deps/libconnection_editor_la-ce-page-ethernet.Tpo -c -o libconnection_editor_la-ce-page-ethernet.lo `test -f 'ce-page-ethernet.c' || echo './'`ce-page-ethernet.c
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../../.. -I../../../ -DG_LOG_DOMAIN=\"-cc-panel\" -DPANEL_ID=\"\" -I./../wireless-security -pthread -I/usr/include/gtk-3.0 -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/pixman-1 -I/usr/include/libpng14 -I/usr/include/libdrm -I/usr/include/gsettings-desktop-schemas -pthread -I/usr/include/NetworkManager -I/usr/include/libnm-glib -I/usr/include/dbus-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/lib/dbus-1.0/include -I/usr/include/libnm-gtk -I/usr/include/gtk-3.0 -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/pixman-1 -I/usr/include/libpng14 -I/usr/include/libdrm -I/usr/include/libmm-glib -I/usr/include/ModemManager -DNM_VPN_CONFIG_DIR=\"/etc/NetworkManager/VPN\" -DNM_VPN_MODULE_DIR=\"/usr/lib/NetworkManager\" -march=x86-64 -mtune=generic -O2 -pipe -I/usr/include/cheese -I/usr/include/gstreamer-1.0 -I/usr/include/libxml2 -MT libconnection_editor_la-net-connection-editor.lo -MD -MP -MF .deps/libconnection_editor_la-net-connection-editor.Tpo -c net-connection-editor.c  -fPIC -DPIC -o .libs/libconnection_editor_la-net-connection-editor.o
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../../.. -I../../../ -DG_LOG_DOMAIN=\"-cc-panel\" -DPANEL_ID=\"\" -I./../wireless-security -pthread -I/usr/include/gtk-3.0 -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/pixman-1 -I/usr/include/libpng14 -I/usr/include/libdrm -I/usr/include/gsettings-desktop-schemas -pthread -I/usr/include/NetworkManager -I/usr/include/libnm-glib -I/usr/include/dbus-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/lib/dbus-1.0/include -I/usr/include/libnm-gtk -I/usr/include/gtk-3.0 -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/pixman-1 -I/usr/include/libpng14 -I/usr/include/libdrm -I/usr/include/libmm-glib -I/usr/include/ModemManager -DNM_VPN_CONFIG_DIR=\"/etc/NetworkManager/VPN\" -DNM_VPN_MODULE_DIR=\"/usr/lib/NetworkManager\" -march=x86-64 -mtune=generic -O2 -pipe -I/usr/include/cheese -I/usr/include/gstreamer-1.0 -I/usr/include/libxml2 -MT libconnection_editor_la-ce-page-reset.lo -MD -MP -MF .deps/libconnection_editor_la-ce-page-reset.Tpo -c ce-page-reset.c  -fPIC -DPIC -o .libs/libconnection_editor_la-ce-page-reset.o
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../../.. -I../../../ -DG_LOG_DOMAIN=\"-cc-panel\" -DPANEL_ID=\"\" -I./../wireless-security -pthread -I/usr/include/gtk-3.0 -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/pixman-1 -I/usr/include/libpng14 -I/usr/include/libdrm -I/usr/include/gsettings-desktop-schemas -pthread -I/usr/include/NetworkManager -I/usr/include/libnm-glib -I/usr/include/dbus-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/lib/dbus-1.0/include -I/usr/include/libnm-gtk -I/usr/include/gtk-3.0 -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/pixman-1 -I/usr/include/libpng14 -I/usr/include/libdrm -I/usr/include/libmm-glib -I/usr/include/ModemManager -DNM_VPN_CONFIG_DIR=\"/etc/NetworkManager/VPN\" -DNM_VPN_MODULE_DIR=\"/usr/lib/NetworkManager\" -march=x86-64 -mtune=generic -O2 -pipe -I/usr/include/cheese -I/usr/include/gstreamer-1.0 -I/usr/include/libxml2 -MT libconnection_editor_la-ce-page-security.lo -MD -MP -MF .deps/libconnection_editor_la-ce-page-security.Tpo -c ce-page-security.c  -fPIC -DPIC -o .libs/libconnection_editor_la-ce-page-security.o
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../../.. -I../../../ -DG_LOG_DOMAIN=\"-cc-panel\" -DPANEL_ID=\"\" -I./../wireless-security -pthread -I/usr/include/gtk-3.0 -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/pixman-1 -I/usr/include/libpng14 -I/usr/include/libdrm -I/usr/include/gsettings-desktop-schemas -pthread -I/usr/include/NetworkManager -I/usr/include/libnm-glib -I/usr/include/dbus-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/lib/dbus-1.0/include -I/usr/include/libnm-gtk -I/usr/include/gtk-3.0 -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/pixman-1 -I/usr/include/libpng14 -I/usr/include/libdrm -I/usr/include/libmm-glib -I/usr/include/ModemManager -DNM_VPN_CONFIG_DIR=\"/etc/NetworkManager/VPN\" -DNM_VPN_MODULE_DIR=\"/usr/lib/NetworkManager\" -march=x86-64 -mtune=generic -O2 -pipe -I/usr/include/cheese -I/usr/include/gstreamer-1.0 -I/usr/include/libxml2 -MT libconnection_editor_la-ce-page-ethernet.lo -MD -MP -MF .deps/libconnection_editor_la-ce-page-ethernet.Tpo -c ce-page-ethernet.c  -fPIC -DPIC -o .libs/libconnection_editor_la-ce-page-ethernet.o
net-connection-editor.c:597:23: error: 'nm_setting_team_get_type' undeclared here (not in a function)
make[6]: *** [libconnection_editor_la-net-connection-editor.lo] Error 1
make[6]: *** Waiting for unfinished jobs....
mv -f .deps/libconnection_editor_la-ce-page-reset.Tpo .deps/libconnection_editor_la-ce-page-reset.Plo
mv -f .deps/libconnection_editor_la-ce-page-ethernet.Tpo .deps/libconnection_editor_la-ce-page-ethernet.Plo
mv -f .deps/libconnection_editor_la-ce-page-security.Tpo .deps/libconnection_editor_la-ce-page-security.Plo
make[6]: Leaving directory `/var/tmp/fst/src/gnome-control-center-3.11.5/panels/network/connection-editor'
make[5]: *** [all] Error 2
make[5]: Leaving directory `/var/tmp/fst/src/gnome-control-center-3.11.5/panels/network/connection-editor'
make[4]: *** [all-recursive] Error 1
make[4]: Leaving directory `/var/tmp/fst/src/gnome-control-center-3.11.5/panels/network'
make[3]: *** [all] Error 2
make[3]: Leaving directory `/var/tmp/fst/src/gnome-control-center-3.11.5/panels/network'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/var/tmp/fst/src/gnome-control-center-3.11.5/panels'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/var/tmp/fst/src/gnome-control-center-3.11.5'
make: *** [all] Error 2

Thanks
Comment 1 Kalev Lember 2014-02-06 21:57:32 UTC 
*** Bug 723799 has been marked as a duplicate of this bug. ***
Comment 2 Dominique Leuenberger 2014-02-07 07:52:16 UTC 
Answering to comment #1 of Bug 723799
> I believe the plan here is to ifdef the team code out so that it builds with
> latest released NM.

I don't think that effort is in anyway needed /useful:
gnome-settings-daemon required geoclue 2.1.2, which in turn as well requires libnm-glib >= 0.9.9.0;

Unless this dependency is also lowered, I would not see a way to install a full GNOME 3.12 stack without a NM recent enough (and unreleased at this moment)
Comment 3 Bastien Nocera 2014-02-12 12:38:44 UTC 
Created attachment 268903 [details] [review]
network: Fix build with NM 0.9.8.x

Team support was only added in the 0.9.9.x branch for the 0.9.10
stable release. It's not available in any releases (beta or stable
ones) yet.
Comment 4 Bastien Nocera 2014-02-12 12:43:13 UTC 
Created attachment 268904 [details] [review]
network: Fix build with NM 0.9.8.x

Team support was only added in the 0.9.9.x branch for the 0.9.10
stable release. It's not available in any releases (beta or stable
ones) yet.
Comment 5 Bastien Nocera 2014-02-12 12:44:35 UTC 
Please test.
Comment 6 Rui Matos 2014-02-12 12:51:37 UTC 
Review of attachment 268904 [details] [review]:

::: panels/network/Makefile.am
@@ +50,3 @@
 	cc-network-panel.h
 
+TEAM_FILES = net-device-team.c net-device-team.h

But you didn't remove them from libnetwork_la_SOURCES

@@ +51,3 @@
 
+TEAM_FILES = net-device-team.c net-device-team.h
+EXTRA_DIST = $(TEAM_FILES)

Shouldn't EXTRA_DIST only include these files in the !HAVE_NM_UNSTABLE case?
Comment 7 Bastien Nocera 2014-02-12 12:56:22 UTC 
Created attachment 268906 [details] [review]
network: Fix build with NM 0.9.8.x

Team support was only added in the 0.9.9.x branch for the 0.9.10
stable release. It's not available in any releases (beta or stable
ones) yet.
Comment 8 Bastien Nocera 2014-02-12 12:57:55 UTC 
(In reply to comment #6)
> Review of attachment 268904 [details] [review]:
> 
> ::: panels/network/Makefile.am
> @@ +50,3 @@
>      cc-network-panel.h
> 
> +TEAM_FILES = net-device-team.c net-device-team.h
> 
> But you didn't remove them from libnetwork_la_SOURCES

Done.

> @@ +51,3 @@
> 
> +TEAM_FILES = net-device-team.c net-device-team.h
> +EXTRA_DIST = $(TEAM_FILES)
> 
> Shouldn't EXTRA_DIST only include these files in the !HAVE_NM_UNSTABLE case?

It won't hurt, no.
Comment 9 Bastien Nocera 2014-02-18 08:48:47 UTC 
Attachment 268906 [details] pushed as f31dbd0 - network: Fix build with NM 0.9.8.x
Comment 10 Michael Catanzaro 2014-02-18 15:54:19 UTC 
(In reply to comment #9)
> Attachment 268906 [details] pushed as f31dbd0 - network: Fix build with NM 0.9.8.x

Bastien, this patch is probably needed on both the 3.10 and 3.8 branches as well, correct?