After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 723651 - avidemux: VBR audio timestamps
avidemux: VBR audio timestamps
Status: RESOLVED NOTABUG
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
1.2.4
Other Linux
: Normal major
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-02-05 07:53 UTC by sangkyu.choi
Modified: 2014-02-25 07:20 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description sangkyu.choi 2014-02-05 07:53:43 UTC
In get_buffer_info function, something is wrong.
Second param is entry->total, but i wonder that it is entry_n.
could you check it?

thank you.


/* given @entry_n in @stream, calculate info such as timestamps and
 * offsets for the entry. */
static void
gst_avi_demux_get_buffer_info (GstAviDemux * avi, GstAviStream * stream,
    guint entry_n, GstClockTime * timestamp, GstClockTime * ts_end,
    guint64 * offset, guint64 * offset_end)
{
  GstAviIndexEntry *entry;

  entry = &stream->index[entry_n];

  if (stream->is_vbr) {
    /* VBR stream next timestamp */
    if (stream->strh->type == GST_RIFF_FCC_auds) {
      if (timestamp)
        *timestamp =
            avi_stream_convert_frames_to_time_unchecked (stream, entry->total);
Comment 1 Mark Nauwelaerts 2014-02-15 14:47:10 UTC
Thanks for your attention and concern.
However, I had a look and afaik it is correct as it is.

See also gst_avi_demux_add_index for how entry->total is determined, and (in many cases?) it might very well be equal to entry_n, but in case it is not there are reasons for it being different.
Comment 2 sangkyu.choi 2014-02-24 05:28:34 UTC
Some files timestamps was problem and 
i have seen more match av sync than before.
I will check again that libsync and some problem case.
Comment 3 Tim-Philipp Müller 2014-02-24 09:42:57 UTC
It would be great if you could make such a problematic file available for download, then we can have a look.
Comment 4 sangkyu.choi 2014-02-25 07:20:28 UTC
thank you^^
After i will check again more detail,
share the url for downloading.
take a few days..