After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 723619 - [patch] Add option to control GNOME Software usage stats
[patch] Add option to control GNOME Software usage stats
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Privacy
git master
Other Linux
: Normal enhancement
: ---
Assigned To: Rui Matos
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-02-04 16:44 UTC by Richard Hughes
Modified: 2014-02-04 18:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch for review (8.93 KB, patch)
2014-02-04 16:44 UTC, Richard Hughes 		needs-work Details | Review
patch for review (10.14 KB, patch)
2014-02-04 17:36 UTC, Richard Hughes 		accepted-commit_now Details | Review

Description Richard Hughes 2014-02-04 16:44:58 UTC 
Created attachment 268084 [details] [review]
patch for review

This allows us to disable / enable the collection of installation and removal in gnome-software, which may be a privacy issue.
Comment 1 Rui Matos 2014-02-04 17:14:04 UTC 
Review of attachment 268084 [details] [review]:

::: panels/privacy/cc-privacy-panel.c
@@ +578,3 @@
+
+  w = GTK_WIDGET (gtk_builder_get_object (self->priv->builder, "software_done"));
+  dialog = self->priv->trash_dialog;

:-)

You need to keep a priv->software_dialog around

::: panels/privacy/privacy.ui
@@ +670,3 @@
+    <property name="can_focus">False</property>
+    <property name="border_width">5</property>
+    <property name="title" translatable="yes">Usage &amp; History</property>

Software Usage ?

@@ +749,3 @@
+            <property name="visible">True</property>
+            <property name="can_focus">False</property>
+            <property name="margin_left">12</property>

This needs to be ..."margin_end">6</property> like in the other dialogs from this file so that widgets align properly with the close button below.
Comment 2 Richard Hughes 2014-02-04 17:36:08 UTC 
Created attachment 268086 [details] [review]
patch for review

Thanks for the speedy review, new patch applied.
Comment 3 Rui Matos 2014-02-04 17:50:26 UTC 
Review of attachment 268086 [details] [review]:

Ok
Comment 4 Richard Hughes 2014-02-04 18:57:27 UTC 
Great, thanks.